Add instructions how to unset ldflags for builds (#147)
Include a reminder to unset LDFLAGS before running 'make install'
This commit is contained in:
committed by
Alessio Treglia
parent
24ae45599a
commit
f41a660cdd
4
.github/PULL_REQUEST_TEMPLATE.md
vendored
4
.github/PULL_REQUEST_TEMPLATE.md
vendored
@@ -1,10 +1,10 @@
|
||||
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺
|
||||
v ✰ Thanks for creating a PR! ✰
|
||||
v ✰ Thanks for creating a PR! ✰
|
||||
v Before smashing the submit button please review the checkboxes.
|
||||
v If a checkbox is n/a - please still include it but + a little note why
|
||||
☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -->
|
||||
|
||||
- Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/gaia/blob/develop/CONTRIBUTING.md#pr-targeting))
|
||||
- Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/gaia/blob/master/CONTRIBUTING.md#pr-targeting))
|
||||
|
||||
- [ ] Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
|
||||
- [ ] Wrote tests
|
||||
|
||||
@@ -31,7 +31,23 @@ git clone -b <latest-release-tag> https://github.com/cosmos/gaia
|
||||
cd gaia && make install
|
||||
```
|
||||
|
||||
> _NOTE_: If you have issues at this step, please check that you have the latest stable version of GO installed.
|
||||
If this command fails due to the following error message, you might have already set `LDFLAGS` prior to running this step.
|
||||
|
||||
```
|
||||
# github.com/cosmos/gaia/cmd/gaiad
|
||||
flag provided but not defined: -L
|
||||
usage: link [options] main.o
|
||||
...
|
||||
make: *** [install] Error 2
|
||||
```
|
||||
|
||||
Unset this environment variable and try again.
|
||||
|
||||
```
|
||||
LDFLAGS="" make install
|
||||
```
|
||||
|
||||
> _NOTE_: If you still have issues at this step, please check that you have the latest stable version of GO installed.
|
||||
|
||||
That will install the `gaiad` and `gaiacli` binaries. Verify that everything is OK:
|
||||
|
||||
|
||||
Reference in New Issue
Block a user