mleku/wasmd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: propagate funds validation errors

Browse Source 
The validation functions on the `tx` type masquerade the root error
message for the `Funds` validation. Having the original error helps to
save time when debugging the cause for a failed tx.

One example is if someone sends multiple funds to a contract execution
without sorting the denoms, which is one of the validations in the
`Coins.Validate` method. With the error propagation, the developer can
quickly determine why the tx failed.
This commit is contained in:
Augusto Elesbão
2023-10-03 12:05:44 +02:00
parent e0da419409
commit 6b8b45c32b
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
x/wasm/types/tx.go
View File

@@ -103,8 +103,8 @@ func (msg MsgInstantiateContract) ValidateBasic() error {
return errorsmod.Wrap(err, "label")
}
if !msg.Funds.IsValid() {
return sdkerrors.ErrInvalidCoins
if err := msg.Funds.Validate(); err != nil {
return errorsmod.Wrap(err, "funds")
}
if len(msg.Admin) != 0 {
@@ -142,8 +142,8 @@ func (msg MsgExecuteContract) ValidateBasic() error {
return errorsmod.Wrap(err, "contract")
}
if !msg.Funds.IsValid() {
return errorsmod.Wrap(sdkerrors.ErrInvalidCoins, "sentFunds")
if err := msg.Funds.Validate(); err != nil {
return errorsmod.Wrap(err, "funds")
}
if err := msg.Msg.ValidateBasic(); err != nil {
return errorsmod.Wrap(err, "payload msg")
@@ -336,8 +336,8 @@ func (msg MsgInstantiateContract2) ValidateBasic() error {
return errorsmod.Wrap(err, "label")
}
if !msg.Funds.IsValid() {
return sdkerrors.ErrInvalidCoins
if err := msg.Funds.Validate(); err != nil {
return errorsmod.Wrap(err, "funds")
}
if len(msg.Admin) != 0 {
@@ -537,8 +537,8 @@ func (msg MsgStoreAndInstantiateContract) ValidateBasic() error {
return errorsmod.Wrap(err, "label")
}
if !msg.Funds.IsValid() {
return sdkerrors.ErrInvalidCoins
if err := msg.Funds.Validate(); err != nil {
return errorsmod.Wrap(err, "funds")
}
if len(msg.Admin) != 0 {