Prashant Varanasi e81582a97d Revert "Optimization for String.Store("")" (#32) ...

This optimization causes data races since we're changing the value field
without using atomics. E.g., a caller who has multiple goroutines
calling `Set("1")` and `Set("")` will race on the access to `s.v` since
one goroutine is trying to read it while the other sets it, neither
using atomic operations.

This reverts commit 16b44f14f0.

2017-11-14 08:16:11 -08:00

1.6 KiB

Raw Blame History

View Raw