36bf277534
This forces all syscall functions, notably filesystem, to return numeric codes as opposed to mapping in two different areas. The result of this change is better consolidation in call sites of `sysfs.FS`, while further refactoring is needed to address consolidation of file errors. Signed-off-by: Adrian Cole <adrian@tetrate.io>
134 lines
3.9 KiB
Go
134 lines
3.9 KiB
Go
//go:build !windows
|
|
|
|
package sysfs
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path"
|
|
"syscall"
|
|
"testing"
|
|
|
|
"github.com/tetratelabs/wazero/internal/platform"
|
|
"github.com/tetratelabs/wazero/internal/testing/require"
|
|
)
|
|
|
|
func TestDirFS_Chown(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
testFS := NewDirFS(tmpDir)
|
|
|
|
require.Zero(t, testFS.Mkdir("dir", 0o0777))
|
|
dirF, errno := testFS.OpenFile("dir", syscall.O_RDONLY, 0)
|
|
require.Zero(t, errno)
|
|
|
|
dirStat, err := dirF.Stat()
|
|
require.NoError(t, err)
|
|
|
|
dirSys := dirStat.Sys().(*syscall.Stat_t)
|
|
|
|
// Similar to TestChown in os_unix_test.go, we can't expect to change
|
|
// owner unless root, and with another user. Instead, test gid.
|
|
gid := os.Getgid()
|
|
groups, err := os.Getgroups()
|
|
require.NoError(t, err)
|
|
|
|
t.Run("-1 parameters means leave alone", func(t *testing.T) {
|
|
require.Zero(t, testFS.Chown("dir", -1, -1))
|
|
checkUidGid(t, path.Join(tmpDir, "dir"), dirSys.Uid, dirSys.Gid)
|
|
})
|
|
|
|
t.Run("change gid, but not uid", func(t *testing.T) {
|
|
require.Zero(t, testFS.Chown("dir", -1, gid))
|
|
checkUidGid(t, path.Join(tmpDir, "dir"), dirSys.Uid, uint32(gid))
|
|
})
|
|
|
|
// Now, try any other groups of the current user.
|
|
for _, g := range groups {
|
|
g := g
|
|
t.Run(fmt.Sprintf("change to gid %d", g), func(t *testing.T) {
|
|
// Test using our Chown
|
|
require.Zero(t, testFS.Chown("dir", -1, g))
|
|
checkUidGid(t, path.Join(tmpDir, "dir"), dirSys.Uid, uint32(g))
|
|
|
|
// Revert back with platform.ChownFile
|
|
require.Zero(t, platform.ChownFile(dirF, -1, gid))
|
|
checkUidGid(t, path.Join(tmpDir, "dir"), dirSys.Uid, uint32(gid))
|
|
})
|
|
}
|
|
|
|
t.Run("not found", func(t *testing.T) {
|
|
require.EqualErrno(t, syscall.ENOENT, testFS.Chown("a", -1, gid))
|
|
})
|
|
}
|
|
|
|
func TestDirFS_Lchown(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
testFS := NewDirFS(tmpDir)
|
|
|
|
require.Zero(t, testFS.Mkdir("dir", 0o0777))
|
|
dirF, errno := testFS.OpenFile("dir", syscall.O_RDONLY, 0)
|
|
require.Zero(t, errno)
|
|
|
|
dirStat, err := dirF.Stat()
|
|
require.NoError(t, err)
|
|
|
|
dirSys := dirStat.Sys().(*syscall.Stat_t)
|
|
|
|
require.Zero(t, testFS.Symlink("dir", "link"))
|
|
linkF, errno := testFS.OpenFile("link", syscall.O_RDONLY, 0)
|
|
require.Zero(t, errno)
|
|
|
|
linkStat, err := linkF.Stat()
|
|
require.NoError(t, err)
|
|
|
|
linkSys := linkStat.Sys().(*syscall.Stat_t)
|
|
|
|
// Similar to TestLchown in os_unix_test.go, we can't expect to change
|
|
// owner unless root, and with another user. Instead, test gid.
|
|
gid := os.Getgid()
|
|
groups, err := os.Getgroups()
|
|
require.NoError(t, err)
|
|
|
|
t.Run("-1 parameters means leave alone", func(t *testing.T) {
|
|
require.Zero(t, testFS.Lchown("link", -1, -1))
|
|
checkUidGid(t, path.Join(tmpDir, "link"), linkSys.Uid, linkSys.Gid)
|
|
})
|
|
|
|
t.Run("change gid, but not uid", func(t *testing.T) {
|
|
require.Zero(t, testFS.Chown("dir", -1, gid))
|
|
checkUidGid(t, path.Join(tmpDir, "link"), linkSys.Uid, uint32(gid))
|
|
// Make sure the target didn't change.
|
|
checkUidGid(t, path.Join(tmpDir, "dir"), dirSys.Uid, dirSys.Gid)
|
|
})
|
|
|
|
// Now, try any other groups of the current user.
|
|
for _, g := range groups {
|
|
g := g
|
|
t.Run(fmt.Sprintf("change to gid %d", g), func(t *testing.T) {
|
|
// Test using our Lchown
|
|
require.Zero(t, testFS.Lchown("link", -1, g))
|
|
checkUidGid(t, path.Join(tmpDir, "link"), linkSys.Uid, uint32(g))
|
|
// Make sure the target didn't change.
|
|
checkUidGid(t, path.Join(tmpDir, "dir"), dirSys.Uid, dirSys.Gid)
|
|
|
|
// Revert back with syscall.Lchown
|
|
require.NoError(t, syscall.Lchown(path.Join(tmpDir, "link"), -1, gid))
|
|
checkUidGid(t, path.Join(tmpDir, "link"), linkSys.Uid, uint32(gid))
|
|
})
|
|
}
|
|
|
|
t.Run("not found", func(t *testing.T) {
|
|
require.EqualErrno(t, syscall.ENOENT, testFS.Lchown("a", -1, gid))
|
|
})
|
|
}
|
|
|
|
// checkUidGid uses lstat to ensure the comparison is against the file, not the
|
|
// target of a symbolic link.
|
|
func checkUidGid(t *testing.T, path string, uid, gid uint32) {
|
|
ls, err := os.Lstat(path)
|
|
require.NoError(t, err)
|
|
sys := ls.Sys().(*syscall.Stat_t)
|
|
require.Equal(t, uid, sys.Uid)
|
|
require.Equal(t, gid, sys.Gid)
|
|
}
|