f040753053
This handles edge cases on rename which were previously skipped in testing. Notably, there are delete flags not possible to propagate in current versions of go, which imply some copy/paste meanwhile. Signed-off-by: Adrian Cole <adrian@tetrate.io> Co-authored-by: Takeshi Yoneda <takeshi@tetrate.io>
46 lines
1.2 KiB
Go
46 lines
1.2 KiB
Go
package platform
|
|
|
|
import (
|
|
"errors"
|
|
"os"
|
|
"syscall"
|
|
)
|
|
|
|
func Rename(from, to string) error {
|
|
if from == to {
|
|
return nil
|
|
}
|
|
|
|
fromStat, err := os.Stat(from)
|
|
if err != nil {
|
|
return syscall.ENOENT
|
|
}
|
|
|
|
if toStat, err := os.Stat(to); err == nil {
|
|
fromIsDir, toIsDir := fromStat.IsDir(), toStat.IsDir()
|
|
if fromIsDir && !toIsDir { // dir to file
|
|
return syscall.ENOTDIR
|
|
} else if !fromIsDir && toIsDir { // file to dir
|
|
return syscall.EISDIR
|
|
} else if !fromIsDir && !toIsDir { // file to file
|
|
// Use os.Rename instead of syscall.Rename in order to allow the overrides of the existing file.
|
|
// Underneath os.Rename, it uses MoveFileEx instead of MoveFile (used by syscall.Rename).
|
|
return os.Rename(from, to)
|
|
} else { // dir to dir
|
|
if dirs, _ := os.ReadDir(to); len(dirs) == 0 {
|
|
// On Windows, renaming to the empty dir will be rejected,
|
|
// so first we remove the empty dir, and then rename to it.
|
|
if err := os.Remove(to); err != nil {
|
|
return err
|
|
}
|
|
return syscall.Rename(from, to)
|
|
}
|
|
return syscall.ENOTEMPTY
|
|
}
|
|
} else if !errors.Is(err, syscall.ENOENT) { // Failed to stat the destination.
|
|
return err
|
|
} else { // Destination not-exist.
|
|
return syscall.Rename(from, to)
|
|
}
|
|
}
|