Files
wazero/internal/sysfs/readfs.go
Crypt Keeper e77f24fe31 sysfs: drops os.File special casing for fs.FS to pass wasi-testsuite (#1174)
This adds a wazero adapter which passes wasi-testsuite 100pct on darwin,
linux and windows. While the main change was adding inodes to the wasi
`fd_readdir` dirents, there was a lot of incidental work needed.

Most of the work was troubleshooting in nature, around windows
specifically, but also wrapping of files. This backfills a lot of tests
and reworked how wrapping works, particularly around windows.

To accommodate this, we drop `os.File` special casing except for
`sysfs.DirFS`

Signed-off-by: Adrian Cole <adrian@tetrate.io>
2023-03-01 13:28:57 +08:00

158 lines
4.1 KiB
Go

package sysfs
import (
"io"
"io/fs"
"os"
"syscall"
"github.com/tetratelabs/wazero/internal/platform"
)
// NewReadFS is used to mask an existing FS for reads. Notably, this allows
// the CLI to do read-only mounts of directories the host user can write, but
// doesn't want the guest wasm to. For example, Python libraries shouldn't be
// written to at runtime by the python wasm file.
func NewReadFS(fs FS) FS {
if _, ok := fs.(*readFS); ok {
return fs
} else if _, ok = fs.(UnimplementedFS); ok {
return fs // unimplemented is read-only
}
return &readFS{fs: fs}
}
type readFS struct {
UnimplementedFS
fs FS
}
// String implements fmt.Stringer
func (r *readFS) String() string {
return r.fs.String()
}
// Open implements the same method as documented on fs.FS
func (r *readFS) Open(name string) (fs.File, error) {
return fsOpen(r, name)
}
// OpenFile implements FS.OpenFile
func (r *readFS) OpenFile(path string, flag int, perm fs.FileMode) (fs.File, error) {
// TODO: Once the real implementation is complete, move the below to
// /RATIONALE.md. Doing this while the type is unstable creates
// documentation drift as we expect a lot of reshaping meanwhile.
//
// Callers of this function expect to either open a valid file handle, or
// get an error, if they can't. We want to return ENOSYS if opened for
// anything except reads.
//
// Instead, we could return a fake no-op file on O_WRONLY. However, this
// hurts observability because a later write error to that file will be on
// a different source code line than the root cause which is opening with
// an unsupported flag.
//
// The tricky part is os.RD_ONLY is typically defined as zero, so while the
// parameter is named flag, the part about opening read vs write isn't a
// typical bitflag. We can't compare against zero anyway, because even if
// there isn't a current flag to OR in with that, there may be in the
// future. What we do instead is mask the flags about read/write mode and
// check if they are the opposite of read or not.
switch flag & (os.O_RDONLY | os.O_WRONLY | os.O_RDWR) {
case os.O_WRONLY, os.O_RDWR:
return nil, syscall.ENOSYS
default: // os.O_RDONLY so we are ok!
}
f, err := r.fs.OpenFile(path, flag, perm)
if err != nil {
return nil, err
}
return maskForReads(f), nil
}
// maskForReads masks the file with read-only interfaces used by wazero.
//
// This technique was adapted from similar code in zipkin-go.
func maskForReads(f fs.File) fs.File {
// Handle the most common types
rf, ok := f.(platform.ReadFile)
pf, pok := f.(platform.PathFile)
switch {
case ok && !pok:
return struct {
platform.ReadFile
}{rf}
case ok && pok:
return struct {
platform.ReadFile
platform.PathFile
}{rf, pf}
}
// The below are the types wazero casts into.
// Note: os.File implements this even for normal files.
d, i0 := f.(fs.ReadDirFile)
ra, i1 := f.(io.ReaderAt)
s, i2 := f.(io.Seeker)
// Wrap any combination of the types above.
switch {
case !i0 && !i1 && !i2: // 0, 0, 0
return struct{ fs.File }{f}
case !i0 && !i1 && i2: // 0, 0, 1
return struct {
fs.File
io.Seeker
}{f, s}
case !i0 && i1 && !i2: // 0, 1, 0
return struct {
fs.File
io.ReaderAt
}{f, ra}
case !i0 && i1 && i2: // 0, 1, 1
return struct {
fs.File
io.ReaderAt
io.Seeker
}{f, ra, s}
case i0 && !i1 && !i2: // 1, 0, 0
return struct {
fs.ReadDirFile
}{d}
case i0 && !i1 && i2: // 1, 0, 1
return struct {
fs.ReadDirFile
io.Seeker
}{d, s}
case i0 && i1 && !i2: // 1, 1, 0
return struct {
fs.ReadDirFile
io.ReaderAt
}{d, ra}
case i0 && i1 && i2: // 1, 1, 1
return struct {
fs.ReadDirFile
io.ReaderAt
io.Seeker
}{d, ra, s}
default:
panic("BUG: unhandled pattern")
}
}
// Lstat implements FS.Lstat
func (r *readFS) Lstat(path string, lstat *platform.Stat_t) error {
return r.fs.Lstat(path, lstat)
}
// Stat implements FS.Stat
func (r *readFS) Stat(path string, stat *platform.Stat_t) error {
return r.fs.Stat(path, stat)
}
// Readlink implements FS.Readlink
func (r *readFS) Readlink(path string, buf []byte) (n int, err error) {
return r.fs.Readlink(path, buf)
}