This reduces some boilerplate by extracting UnimplementedFS from the existing FS implementations, such that it returns ENOSYS. This also removes inconsistency where some methods on FS returned syscall.Errno and others PathError. Note: this doesn't get rid of all PathError, yet. We still need to create a syscallfs.File type which would be able to do that. This is just one preliminary cleanup before refactoring out the `fs.FS` embedding from `syscallfs.DS`. P.S. naming convention is arbitrary, so I took UnimplementedXXX from grpc. This pattern is used a lot of places, also proxy-wasm-go-sdk, e.g. `DefaultVMContext`. Signed-off-by: Adrian Cole <adrian@tetrate.io>
336 lines
8.2 KiB
Go
336 lines
8.2 KiB
Go
package sys
|
|
|
|
import (
|
|
"bytes"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/tetratelabs/wazero/internal/platform"
|
|
"github.com/tetratelabs/wazero/internal/syscallfs"
|
|
testfs "github.com/tetratelabs/wazero/internal/testing/fs"
|
|
"github.com/tetratelabs/wazero/internal/testing/require"
|
|
"github.com/tetratelabs/wazero/sys"
|
|
)
|
|
|
|
func TestContext_FS(t *testing.T) {
|
|
sysCtx := DefaultContext(syscallfs.UnimplementedFS{})
|
|
|
|
fsc, err := NewFSContext(nil, nil, nil, syscallfs.UnimplementedFS{})
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, fsc, sysCtx.FS())
|
|
}
|
|
|
|
func TestDefaultSysContext(t *testing.T) {
|
|
sysCtx, err := NewContext(
|
|
0, // max
|
|
nil, // args
|
|
nil, // environ
|
|
nil, // stdin
|
|
nil, // stdout
|
|
nil, // stderr
|
|
nil, // randSource
|
|
nil, 0, // walltime, walltimeResolution
|
|
nil, 0, // nanotime, nanotimeResolution
|
|
nil, // nanosleep
|
|
testfs.FS{}, // fs
|
|
)
|
|
require.NoError(t, err)
|
|
|
|
require.Nil(t, sysCtx.Args())
|
|
require.Zero(t, sysCtx.ArgsSize())
|
|
require.Nil(t, sysCtx.Environ())
|
|
require.Zero(t, sysCtx.EnvironSize())
|
|
// To compare functions, we can only compare pointers, but the pointer will
|
|
// change. Hence, we have to compare the results instead.
|
|
sec, _ := sysCtx.Walltime()
|
|
require.Equal(t, platform.FakeEpochNanos/time.Second.Nanoseconds(), sec)
|
|
require.Equal(t, sys.ClockResolution(1_000), sysCtx.WalltimeResolution())
|
|
require.Zero(t, sysCtx.Nanotime()) // See above on functions.
|
|
require.Equal(t, sys.ClockResolution(1), sysCtx.NanotimeResolution())
|
|
require.Equal(t, &ns, sysCtx.nanosleep)
|
|
require.Equal(t, platform.NewFakeRandSource(), sysCtx.RandSource())
|
|
|
|
testFS := syscallfs.Adapt(testfs.FS{}, "/")
|
|
expectedFS, _ := NewFSContext(nil, nil, nil, testFS)
|
|
|
|
expectedOpenedFiles := FileTable{}
|
|
expectedOpenedFiles.Insert(noopStdin)
|
|
expectedOpenedFiles.Insert(noopStdout)
|
|
expectedOpenedFiles.Insert(noopStderr)
|
|
expectedOpenedFiles.Insert(&FileEntry{IsPreopen: true, Name: "", File: &lazyDir{fs: testFS}})
|
|
|
|
require.Equal(t, expectedOpenedFiles, expectedFS.openedFiles)
|
|
require.Equal(t, expectedFS, sysCtx.FS())
|
|
}
|
|
|
|
func TestNewContext_Args(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
args [][]byte
|
|
maxSize uint32
|
|
expectedSize uint32
|
|
expectedErr string
|
|
}{
|
|
{
|
|
name: "ok",
|
|
maxSize: 10,
|
|
args: [][]byte{[]byte("a"), []byte("bc")},
|
|
expectedSize: 5,
|
|
},
|
|
{
|
|
name: "exceeds max count",
|
|
maxSize: 1,
|
|
args: [][]byte{[]byte("a"), []byte("bc")},
|
|
expectedErr: "args invalid: exceeds maximum count",
|
|
},
|
|
{
|
|
name: "exceeds max size",
|
|
maxSize: 4,
|
|
args: [][]byte{[]byte("a"), []byte("bc")},
|
|
expectedErr: "args invalid: exceeds maximum size",
|
|
},
|
|
{
|
|
name: "null character",
|
|
maxSize: 10,
|
|
args: [][]byte{[]byte("a"), {'b', 0}},
|
|
expectedErr: "args invalid: contains NUL character",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
tc := tt
|
|
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
sysCtx, err := NewContext(
|
|
tc.maxSize, // max
|
|
tc.args,
|
|
nil, // environ
|
|
bytes.NewReader(make([]byte, 0)), // stdin
|
|
nil, // stdout
|
|
nil, // stderr
|
|
nil, // randSource
|
|
nil, 0, // walltime, walltimeResolution
|
|
nil, 0, // nanotime, nanotimeResolution
|
|
nil, // nanosleep
|
|
nil, // fs
|
|
)
|
|
if tc.expectedErr == "" {
|
|
require.Nil(t, err)
|
|
require.Equal(t, tc.args, sysCtx.Args())
|
|
require.Equal(t, tc.expectedSize, sysCtx.ArgsSize())
|
|
} else {
|
|
require.EqualError(t, err, tc.expectedErr)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestNewContext_Environ(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
environ [][]byte
|
|
maxSize uint32
|
|
expectedSize uint32
|
|
expectedErr string
|
|
}{
|
|
{
|
|
name: "ok",
|
|
maxSize: 10,
|
|
environ: [][]byte{[]byte("a=b"), []byte("c=de")},
|
|
expectedSize: 9,
|
|
},
|
|
{
|
|
name: "exceeds max count",
|
|
maxSize: 1,
|
|
environ: [][]byte{[]byte("a=b"), []byte("c=de")},
|
|
expectedErr: "environ invalid: exceeds maximum count",
|
|
},
|
|
{
|
|
name: "exceeds max size",
|
|
maxSize: 4,
|
|
environ: [][]byte{[]byte("a=b"), []byte("c=de")},
|
|
expectedErr: "environ invalid: exceeds maximum size",
|
|
},
|
|
{
|
|
name: "null character",
|
|
maxSize: 10,
|
|
environ: [][]byte{[]byte("a=b"), append([]byte("c=d"), 0)},
|
|
expectedErr: "environ invalid: contains NUL character",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
tc := tt
|
|
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
sysCtx, err := NewContext(
|
|
tc.maxSize, // max
|
|
nil, // args
|
|
tc.environ,
|
|
bytes.NewReader(make([]byte, 0)), // stdin
|
|
nil, // stdout
|
|
nil, // stderr
|
|
nil, // randSource
|
|
nil, 0, // walltime, walltimeResolution
|
|
nil, 0, // nanotime, nanotimeResolution
|
|
nil, // nanosleep
|
|
nil, // fs
|
|
)
|
|
if tc.expectedErr == "" {
|
|
require.Nil(t, err)
|
|
require.Equal(t, tc.environ, sysCtx.Environ())
|
|
require.Equal(t, tc.expectedSize, sysCtx.EnvironSize())
|
|
} else {
|
|
require.EqualError(t, err, tc.expectedErr)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestNewContext_Walltime(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
time *sys.Walltime
|
|
resolution sys.ClockResolution
|
|
expectedErr string
|
|
}{
|
|
{
|
|
name: "ok",
|
|
time: platform.NewFakeWalltime(),
|
|
resolution: 3,
|
|
},
|
|
{
|
|
name: "invalid resolution",
|
|
time: platform.NewFakeWalltime(),
|
|
resolution: 0,
|
|
expectedErr: "invalid Walltime resolution: 0",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
tc := tt
|
|
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
sysCtx, err := NewContext(
|
|
0, // max
|
|
nil, // args
|
|
nil,
|
|
nil, // stdin
|
|
nil, // stdout
|
|
nil, // stderr
|
|
nil, // randSource
|
|
tc.time, tc.resolution, // walltime, walltimeResolution
|
|
nil, 0, // nanotime, nanotimeResolution
|
|
nil, // nanosleep
|
|
nil, // fs
|
|
)
|
|
if tc.expectedErr == "" {
|
|
require.Nil(t, err)
|
|
require.Equal(t, tc.time, sysCtx.walltime)
|
|
require.Equal(t, tc.resolution, sysCtx.WalltimeResolution())
|
|
} else {
|
|
require.EqualError(t, err, tc.expectedErr)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestNewContext_Nanotime(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
time *sys.Nanotime
|
|
resolution sys.ClockResolution
|
|
expectedErr string
|
|
}{
|
|
{
|
|
name: "ok",
|
|
time: platform.NewFakeNanotime(),
|
|
resolution: 3,
|
|
},
|
|
{
|
|
name: "invalid resolution",
|
|
time: platform.NewFakeNanotime(),
|
|
resolution: 0,
|
|
expectedErr: "invalid Nanotime resolution: 0",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
tc := tt
|
|
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
sysCtx, err := NewContext(
|
|
0, // max
|
|
nil, // args
|
|
nil,
|
|
nil, // stdin
|
|
nil, // stdout
|
|
nil, // stderr
|
|
nil, // randSource
|
|
nil, 0, // nanotime, nanotimeResolution
|
|
tc.time, tc.resolution, // nanotime, nanotimeResolution
|
|
nil, // nanosleep
|
|
nil, // fs
|
|
)
|
|
if tc.expectedErr == "" {
|
|
require.Nil(t, err)
|
|
require.Equal(t, tc.time, sysCtx.nanotime)
|
|
require.Equal(t, tc.resolution, sysCtx.NanotimeResolution())
|
|
} else {
|
|
require.EqualError(t, err, tc.expectedErr)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_clockResolutionInvalid(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
resolution sys.ClockResolution
|
|
expected bool
|
|
}{
|
|
{
|
|
name: "ok",
|
|
resolution: 1,
|
|
},
|
|
{
|
|
name: "zero",
|
|
resolution: 0,
|
|
expected: true,
|
|
},
|
|
{
|
|
name: "too big",
|
|
resolution: sys.ClockResolution(time.Hour.Nanoseconds() * 2),
|
|
expected: true,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
tc := tt
|
|
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
require.Equal(t, tc.expected, clockResolutionInvalid(tc.resolution))
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestNewContext_Nanosleep(t *testing.T) {
|
|
var aNs sys.Nanosleep = func(int64) {}
|
|
sysCtx, err := NewContext(
|
|
0, // max
|
|
nil, // args
|
|
nil,
|
|
nil, // stdin
|
|
nil, // stdout
|
|
nil, // stderr
|
|
nil, // randSource
|
|
nil, 0, // Nanosleep, NanosleepResolution
|
|
nil, 0, // Nanosleep, NanosleepResolution
|
|
&aNs, // nanosleep
|
|
nil, // fs
|
|
)
|
|
require.Nil(t, err)
|
|
require.Equal(t, &aNs, sysCtx.nanosleep)
|
|
}
|