Files
wazero/internal/sys/fs_test.go
Crypt Keeper 2e13f57f56 wasi: enforce fd_preXXX functions only work on pre-opened files (#919)
At the moment, the only pre-open support we have is the file system
itself (root a.k.a. / or file-descriptor 3). We may in the future add
the ability to pre-open sockets, but in any case, this is where we are
today.

This change hardens logic around fd_preXXX functions, ensuring they only
work on actual pre-opens. This also fixes the path returned in filestat
as we sometimes returned a full path, when typically the basename is the
only part that can be returned.

Signed-off-by: Adrian Cole <adrian@tetrate.io>
2022-12-13 16:42:53 +09:00

205 lines
4.5 KiB
Go

package sys
import (
"context"
"embed"
"errors"
"io"
"io/fs"
"os"
"path"
"testing"
"testing/fstest"
testfs "github.com/tetratelabs/wazero/internal/testing/fs"
"github.com/tetratelabs/wazero/internal/testing/require"
)
// testCtx is an arbitrary, non-default context. Non-nil also prevents linter errors.
var testCtx = context.WithValue(context.Background(), struct{}{}, "arbitrary")
//go:embed testdata
var testdata embed.FS
func TestNewFSContext(t *testing.T) {
embedFS, err := fs.Sub(testdata, "testdata")
require.NoError(t, err)
// Test various usual configuration for the file system.
tests := []struct {
name string
fs fs.FS
expectOsFile bool
}{
{
name: "embed.FS",
fs: embedFS,
},
{
name: "os.DirFS",
// Don't use "testdata" because it may not be present in
// cross-architecture (a.k.a. scratch) build containers.
fs: os.DirFS("."),
expectOsFile: true,
},
{
name: "fstest.MapFS",
fs: fstest.MapFS{},
},
}
for _, tt := range tests {
tc := tt
t.Run(tc.name, func(b *testing.T) {
fsc, err := NewFSContext(tc.fs)
require.NoError(t, err)
defer fsc.Close(testCtx)
require.Equal(t, tc.fs, fsc.fs)
require.Equal(t, "/", fsc.openedFiles[FdRoot].Name)
rootFile := fsc.openedFiles[FdRoot].File
require.NotNil(t, rootFile)
_, osFile := rootFile.(*os.File)
require.Equal(t, tc.expectOsFile, osFile)
})
}
}
func TestEmptyFS(t *testing.T) {
testFS := EmptyFS
t.Run("validates path", func(t *testing.T) {
f, err := testFS.Open("/foo.txt")
require.Nil(t, f)
require.EqualError(t, err, "open /foo.txt: invalid argument")
})
t.Run("path not found", func(t *testing.T) {
f, err := testFS.Open("foo.txt")
require.Nil(t, f)
require.EqualError(t, err, "open foo.txt: file does not exist")
})
}
func TestEmptyFSContext(t *testing.T) {
testFS := emptyFSContext
expected := &FSContext{
fs: EmptyFS,
openedFiles: map[uint32]*FileEntry{},
lastFD: 2,
}
t.Run("OpenFile doesn't affect state", func(t *testing.T) {
fd, err := testFS.OpenFile(testCtx, "foo.txt")
require.Zero(t, fd)
require.EqualError(t, err, "open foo.txt: file does not exist")
// Ensure this didn't modify state
require.Equal(t, expected, testFS)
})
t.Run("Close doesn't affect state", func(t *testing.T) {
err := testFS.Close(testCtx)
require.NoError(t, err)
// Ensure this didn't modify state
require.Equal(t, expected, testFS)
})
}
func TestContext_File(t *testing.T) {
embedFS, err := fs.Sub(testdata, "testdata")
require.NoError(t, err)
fsc, err := NewFSContext(embedFS)
require.NoError(t, err)
defer fsc.Close(testCtx)
tests := []struct {
name string
expected string
}{
{
name: "empty.txt",
},
{
name: "test.txt",
expected: "animals\n",
},
{
name: "sub/test.txt",
expected: "greet sub dir\n",
},
{
name: "sub/sub/test.txt",
expected: "greet sub sub dir\n",
},
}
for _, tt := range tests {
tc := tt
t.Run(tc.name, func(b *testing.T) {
fd, err := fsc.OpenFile(testCtx, tc.name)
require.NoError(t, err)
defer fsc.CloseFile(testCtx, fd)
f, ok := fsc.OpenedFile(testCtx, fd)
require.True(t, ok)
stat, err := f.File.Stat()
require.NoError(t, err)
// Ensure the name is the basename and matches the stat name.
require.Equal(t, path.Base(tc.name), f.Name)
require.Equal(t, f.Name, stat.Name())
buf := make([]byte, stat.Size())
size, err := f.File.Read(buf)
if err != nil {
require.Equal(t, io.EOF, err)
}
require.Equal(t, stat.Size(), int64(size))
require.Equal(t, tc.expected, string(buf[:size]))
})
}
}
func TestContext_Close(t *testing.T) {
fsc, err := NewFSContext(testfs.FS{"foo": &testfs.File{}})
require.NoError(t, err)
// Verify base case
require.Equal(t, 1, len(fsc.openedFiles))
_, err = fsc.OpenFile(testCtx, "foo")
require.NoError(t, err)
require.Equal(t, 2, len(fsc.openedFiles))
// Closing should not err.
require.NoError(t, fsc.Close(testCtx))
// Verify our intended side-effect
require.Zero(t, len(fsc.openedFiles))
// Verify no error closing again.
require.NoError(t, fsc.Close(testCtx))
}
func TestContext_Close_Error(t *testing.T) {
file := &testfs.File{CloseErr: errors.New("error closing")}
fsc, err := NewFSContext(testfs.FS{"foo": file})
require.NoError(t, err)
// open another file
_, err = fsc.OpenFile(testCtx, "foo")
require.NoError(t, err)
require.EqualError(t, fsc.Close(testCtx), "error closing")
// Paths should clear even under error
require.Zero(t, len(fsc.openedFiles), "expected no opened files")
}