From f2c8caaf9228944bea8c34b942796b9dee71a95b Mon Sep 17 00:00:00 2001 From: Anuraag Agrawal Date: Wed, 17 May 2023 12:51:20 +0900 Subject: [PATCH] Generically convert to string in hammer recovery (#1479) Signed-off-by: Anuraag Agrawal --- internal/testing/hammer/hammer.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/internal/testing/hammer/hammer.go b/internal/testing/hammer/hammer.go index bee9ccf1..82e86961 100644 --- a/internal/testing/hammer/hammer.go +++ b/internal/testing/hammer/hammer.go @@ -74,7 +74,9 @@ func (h *hammer) Run(test func(name string), onRunning func()) { go func() { // Launch goroutine 'p' defer func() { // Ensure each require.XX failure is visible on hammer test fail. if recovered := recover(); recovered != nil { - h.t.Error(recovered.(string)) + // Has been seen to be string, runtime.errorString, and it may be others. Let + // printing take care of conversion in a generic way. + h.t.Error(recovered) } finished <- 1 }()