Fixes FuncRef global initialization with imported globals (#888)

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
This commit is contained in:
Takeshi Yoneda
2022-12-06 14:32:12 +09:00
committed by GitHub
parent af8105ba0e
commit b8adb361e8
13 changed files with 111 additions and 103 deletions

View File

@@ -9,6 +9,8 @@ import (
"github.com/tetratelabs/wazero"
"github.com/tetratelabs/wazero/internal/platform"
"github.com/tetratelabs/wazero/internal/testing/require"
"github.com/tetratelabs/wazero/internal/wasm"
"github.com/tetratelabs/wazero/internal/wasm/binary"
)
var ctx = context.Background()
@@ -343,3 +345,38 @@ func Test874(t *testing.T) {
require.NoError(t, err)
})
}
func Test888(t *testing.T) {
// This tests that importing FuncRef type globals and using it as an initialization of the locally-defined
// FuncRef global works fine.
run(t, func(t *testing.T, r wazero.Runtime) {
imported := binary.EncodeModule(&wasm.Module{
MemorySection: &wasm.Memory{Min: 0, Max: 5, IsMaxEncoded: true},
GlobalSection: []*wasm.Global{
{
Type: &wasm.GlobalType{
ValType: wasm.ValueTypeFuncref,
Mutable: false,
},
Init: &wasm.ConstantExpression{
Opcode: wasm.OpcodeRefNull,
Data: []byte{wasm.ValueTypeFuncref},
},
},
},
ExportSection: []*wasm.Export{
{Name: "", Type: wasm.ExternTypeGlobal, Index: 0},
{Name: "s", Type: wasm.ExternTypeMemory, Index: 0},
},
})
_, err := r.InstantiateModuleFromBinary(ctx, imported)
require.NoError(t, err)
compiled, err := r.CompileModule(ctx, getWasmBinary(t, 888))
require.NoError(t, err)
_, err = r.InstantiateModule(ctx, compiled, wazero.NewModuleConfig().WithName("test"))
require.NoError(t, err)
})
}