From b4f47d9695cf81ad85751b49f603e32145fcdb9c Mon Sep 17 00:00:00 2001 From: Takeshi Yoneda Date: Tue, 12 Mar 2024 16:57:00 +0900 Subject: [PATCH] fuzz: adds --no-trace-compares flag by default (#2152) Signed-off-by: Takeshi Yoneda --- Makefile | 10 ++++++---- internal/integration_test/fuzz/README.md | 8 ++++---- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/Makefile b/Makefile index 53db2d0c..e5ae8a26 100644 --- a/Makefile +++ b/Makefile @@ -272,14 +272,16 @@ clean: ## Ensure a clean build @rm -rf dist build coverage.txt @go clean -testcache +fuzz_default_flags := --no-trace-compares --sanitizer=none -- -rss_limit_mb=8192 + fuzz_timeout_seconds ?= 10 .PHONY: fuzz fuzz: @cd internal/integration_test/fuzz && cargo test - @cd internal/integration_test/fuzz && cargo fuzz run logging_no_diff --sanitizer=none -- -rss_limit_mb=8192 -max_total_time=$(fuzz_timeout_seconds) - @cd internal/integration_test/fuzz && cargo fuzz run no_diff --sanitizer=none -- -rss_limit_mb=8192 -max_total_time=$(fuzz_timeout_seconds) - @cd internal/integration_test/fuzz && cargo fuzz run memory_no_diff --sanitizer=none -- -rss_limit_mb=8192 -max_total_time=$(fuzz_timeout_seconds) - @cd internal/integration_test/fuzz && cargo fuzz run validation --sanitizer=none -- -rss_limit_mb=8192 -max_total_time=$(fuzz_timeout_seconds) + @cd internal/integration_test/fuzz && cargo fuzz run logging_no_diff $(fuzz_default_flags) -max_total_time=$(fuzz_timeout_seconds) + @cd internal/integration_test/fuzz && cargo fuzz run no_diff $(fuzz_default_flags) -max_total_time=$(fuzz_timeout_seconds) + @cd internal/integration_test/fuzz && cargo fuzz run memory_no_diff $(fuzz_default_flags) -max_total_time=$(fuzz_timeout_seconds) + @cd internal/integration_test/fuzz && cargo fuzz run validation $(fuzz_default_flags) -max_total_time=$(fuzz_timeout_seconds) libsodium: cd ./internal/integration_test/libsodium/testdata && \ diff --git a/internal/integration_test/fuzz/README.md b/internal/integration_test/fuzz/README.md index ef28f58b..aeda572a 100644 --- a/internal/integration_test/fuzz/README.md +++ b/internal/integration_test/fuzz/README.md @@ -41,16 +41,16 @@ See `cargo fuzz run --help` for the options. Especially, the following flags are ``` # Running the `no_diff` target with 15 concurrent jobs with total runnig time with 2hrs and 8GB memory limit. -$ cargo fuzz run no_diff --sanitizer=none -- -rss_limit_mb=8192 -max_len=5000000 -max_total_time=7200 -jobs=15 +$ cargo fuzz run no_diff --sanitizer=none --no-trace-compares -- -rss_limit_mb=8192 -max_len=5000000 -max_total_time=7200 -jobs=15 # Running the `memory_no_diff` target with 15 concurrent jobs with timeout 2hrs and setting timeout per fuzz case to 30s. -$ cargo fuzz run memory_no_diff --sanitizer=none -- -timeout=30 -max_total_time=7200 -jobs=15 +$ cargo fuzz run memory_no_diff --sanitizer=none --no-trace-compares -- -timeout=30 -max_total_time=7200 -jobs=15 # Running the `validation` target with 4 concurrent jobs with timeout 2hrs and setting timeout per fuzz case to 30s. -# cargo fuzz run validation --sanitizer=none -- -timeout=30 -max_total_time=7200 -jobs=4 +# cargo fuzz run validation --sanitizer=none --no-trace-compares -- -timeout=30 -max_total_time=7200 -jobs=4 ``` -Note that `--sanitizer=none` is always recommended to use because the sanitizer is not useful for our use case plus this will speed up the fuzzing by like multiple times. +Note that `--sanitizer=none` and `--no-trace-compares` are always recommended to use because the sanitizer is not useful for our use case plus this will speed up the fuzzing by like multiple times. ### Reproduce errors