Makes memory limit configurable and a compile error (#419)

This allows users to reduce the memory limit per module below 4 Gi. This
is often needed because Wasm routinely leaves off the max, which implies
spec max (4 Gi). This uses Ki Gi etc in error messages because the spec
chooses to, though we can change to make it less awkward.

This also fixes an issue where we instantiated an engine inside config.

Signed-off-by: Adrian Cole <adrian@tetrate.io>
This commit is contained in:
Crypt Keeper
2022-03-31 08:57:28 +08:00
committed by GitHub
parent 81c2414fff
commit 8f461f6f12
26 changed files with 410 additions and 208 deletions

View File

@@ -141,9 +141,9 @@ func TestModule_allDeclarations(t *testing.T) {
// Memories.
{
module: &Module{
ImportSection: []*Import{{Type: ExternTypeMemory, DescMem: &limitsType{Min: 1}}},
ImportSection: []*Import{{Type: ExternTypeMemory, DescMem: &Memory{Min: 1, Max: 10}}},
},
expectedMemory: &Memory{Min: 1},
expectedMemory: &Memory{Min: 1, Max: 10},
},
{
module: &Module{
@@ -643,7 +643,7 @@ func TestModule_validateExports(t *testing.T) {
name: "memory out of range",
enabledFeatures: Features20191205,
exportSection: map[string]*Export{"e1": {Type: ExternTypeMemory, Index: 0}},
table: &Memory{},
table: &limitsType{},
expectedErr: `memory for export["e1"] out of range`,
},
} {
@@ -720,9 +720,9 @@ func TestModule_buildMemoryInstance(t *testing.T) {
t.Run("non-nil", func(t *testing.T) {
min := uint32(1)
max := uint32(10)
m := Module{MemorySection: &Memory{Min: min, Max: &max}}
m := Module{MemorySection: &Memory{Min: min, Max: max}}
mem := m.buildMemory()
require.Equal(t, min, mem.Min)
require.Equal(t, max, *mem.Max)
require.Equal(t, max, mem.Max)
})
}