mleku/wazero
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Allow ModuleConfig.WithName("") to clear the module name (#1277)

Browse Source 
We currently allow clearing other config with nil, such as FSConfig.
However, we missed a spot as internally we couldn't differentiate
between name never set, or explicitly set to empty. Now, when someone
sets the module name to empty, the name in the binary section is
ignored.

Signed-off-by: Adrian Cole <adrian@tetrate.io>
This commit is contained in:
Crypt Keeper
2023-03-23 08:53:14 +01:00
committed by GitHub
parent d8f356e644
commit 53bb95eeaa
4 changed files with 37 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
runtime_test.go
View File

@@ -446,19 +446,23 @@ func TestRuntime_InstantiateModule_WithName(t *testing.T) {
internal := r.(*runtime)
m1, err := r.InstantiateModule(testCtx, base, NewModuleConfig().WithName("1"))
require.NoError(t, err)
require.Equal(t, "1", m1.Name())
require.Nil(t, internal.Module("0"))
require.Equal(t, internal.Module("1"), m1)
m2, err := r.InstantiateModule(testCtx, base, NewModuleConfig().WithName("2"))
require.NoError(t, err)
require.Equal(t, "2", m2.Name())
require.Nil(t, internal.Module("0"))
require.Equal(t, internal.Module("2"), m2)
// Empty name module shouldn't be returned via Module() for future optimization.
_, err = r.InstantiateModule(testCtx, base, NewModuleConfig().WithName(""))
m3, err := r.InstantiateModule(testCtx, base, NewModuleConfig().WithName(""))
require.NoError(t, err)
require.Equal(t, "", m3.Name())
ret := internal.Module("")
require.Nil(t, ret)
}