mleku/wazero
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

moremath: align NaN handling with amd64/arm64 compilers (#705)

Browse Source 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
This commit is contained in:
Takeshi Yoneda
2022-07-21 12:03:05 +09:00
committed by GitHub
parent 0da1af2d51
commit 303b14e67c
2 changed files with 154 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

68
internal/moremath/moremath_test.go
View File

@@ -137,3 +137,71 @@ func TestUniOp_NaNPropagation(t *testing.T) {
})
}
}
func Test_returnF32UniOp(t *testing.T) {
for _, tc := range []struct {
original, result, exp uint32
}{
{result: math.Float32bits(1.1), exp: math.Float32bits(1.1)},
{original: 1.0, result: math.Float32bits(float32(math.NaN())), exp: F32CanonicalNaNBits},
{original: F32ArithmeticNaNBits, result: math.Float32bits(float32(math.NaN())), exp: F32ArithmeticNaNBits},
// Even if the MSB of the payload is unset (signaling NaN), the result must it set, therefore an arithmetic NaN.
{original: F32ArithmeticNaNBits ^ (1 << 22), result: math.Float32bits(float32(math.NaN())), exp: F32ArithmeticNaNBits},
} {
actual := returnF32UniOp(math.Float32frombits(tc.original), math.Float32frombits(tc.result))
require.Equal(t, tc.exp, math.Float32bits(actual))
}
}
func Test_returnF64UniOp(t *testing.T) {
for _, tc := range []struct {
original, result, exp uint64
}{
{result: math.Float64bits(1.1), exp: math.Float64bits(1.1)},
{original: 1.0, result: math.Float64bits(math.NaN()), exp: F64CanonicalNaNBits},
{original: F64ArithmeticNaNBits, result: math.Float64bits(math.NaN()), exp: F64ArithmeticNaNBits},
// Even if the MSB of the payload is unset (signaling NaN), the result must it set, therefore an arithmetic NaN.
{original: F64ArithmeticNaNBits ^ (1 << 51), result: math.Float64bits(math.NaN()), exp: F64ArithmeticNaNBits},
} {
actual := returnF64UniOp(math.Float64frombits(tc.original), math.Float64frombits(tc.result))
require.Equal(t, tc.exp, math.Float64bits(actual))
}
}
func Test_returnF32NaNBinOp(t *testing.T) {
for _, tc := range []struct {
x, y, exp uint32
}{
{x: F32CanonicalNaNBits, y: F32CanonicalNaNBits, exp: F32CanonicalNaNBits},
{x: F32CanonicalNaNBits, y: 0, exp: F32CanonicalNaNBits},
{x: 0, y: F32CanonicalNaNBits, exp: F32CanonicalNaNBits},
{x: F32ArithmeticNaNBits, y: F32ArithmeticNaNBits, exp: F32ArithmeticNaNBits},
{x: F32ArithmeticNaNBits, y: 0, exp: F32ArithmeticNaNBits},
{x: 0, y: F32ArithmeticNaNBits, exp: F32ArithmeticNaNBits},
// Even if the MSB of the payload is unset (signaling NaN), the result must it set, therefore an arithmetic NaN.
{x: 0, y: F32ArithmeticNaNBits ^ (1 << 22), exp: F32ArithmeticNaNBits},
{x: F32ArithmeticNaNBits ^ (1 << 22), y: 0, exp: F32ArithmeticNaNBits},
} {
actual := returnF32NaNBinOp(math.Float32frombits(tc.x), math.Float32frombits(tc.y))
require.Equal(t, tc.exp, math.Float32bits(actual))
}
}
func Test_returnF64NaNBinOp(t *testing.T) {
for _, tc := range []struct {
x, y, exp uint64
}{
{x: F64CanonicalNaNBits, y: F64CanonicalNaNBits, exp: F64CanonicalNaNBits},
{x: F64CanonicalNaNBits, y: 0, exp: F64CanonicalNaNBits},
{x: 0, y: F64CanonicalNaNBits, exp: F64CanonicalNaNBits},
{x: F64ArithmeticNaNBits, y: F64ArithmeticNaNBits, exp: F64ArithmeticNaNBits},
{x: F64ArithmeticNaNBits, y: 0, exp: F64ArithmeticNaNBits},
{x: 0, y: F64ArithmeticNaNBits, exp: F64ArithmeticNaNBits},
// Even if the MSB of the payload is unset (signaling NaN), the result must it set, therefore an arithmetic NaN.
{x: 0, y: F64ArithmeticNaNBits ^ (1 << 51), exp: F64ArithmeticNaNBits},
{x: F64ArithmeticNaNBits ^ (1 << 51), y: 0, exp: F64ArithmeticNaNBits},
} {
actual := returnF64NaNBinOp(math.Float64frombits(tc.x), math.Float64frombits(tc.y))
require.Equal(t, tc.exp, math.Float64bits(actual))
}
}