mleku/wazero
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

regalloc: removes unused Instr.AddedBeforeRegAlloc api (#2268)

Browse Source 
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This commit is contained in:
Takeshi Yoneda
2024-06-25 10:14:12 -07:00
committed by GitHub
parent 8db4d0fbc1
commit 200980ef11
6 changed files with 4 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
internal/engine/wazevo/backend/isa/amd64/instr.go
View File

@@ -26,9 +26,6 @@ func (i *instruction) IsIndirectCall() bool { return i.kind == callIndirect }
// IsReturn implements regalloc.Instr.
func (i *instruction) IsReturn() bool { return i.kind == ret }
// AddedBeforeRegAlloc implements regalloc.Instr.
func (i *instruction) AddedBeforeRegAlloc() bool { return i.addedBeforeRegAlloc }
// String implements regalloc.Instr.
func (i *instruction) String() string {
switch i.kind {

4
internal/engine/wazevo/backend/isa/amd64/machine_regalloc.go
View File

@@ -165,7 +165,7 @@ func (pos *labelPosition) InstrIteratorNext() *instruction {
pos.cur = instr
if instr == nil {
return nil
} else if instr.AddedBeforeRegAlloc() {
} else if instr.addedBeforeRegAlloc {
// Only concerned about the instruction added before regalloc.
return instr
}
@@ -188,7 +188,7 @@ func (pos *labelPosition) InstrRevIteratorNext() *instruction {
pos.cur = instr
if instr == nil {
return nil
} else if instr.AddedBeforeRegAlloc() {
} else if instr.addedBeforeRegAlloc {
// Only concerned about the instruction added before regalloc.
return instr
}

5
internal/engine/wazevo/backend/isa/arm64/instr.go
View File

@@ -51,11 +51,6 @@ func (i *instruction) IsReturn() bool {
return i.kind == ret
}
// AddedBeforeRegAlloc implements regalloc.Instr AddedBeforeRegAlloc.
func (i *instruction) AddedBeforeRegAlloc() bool {
return i.addedBeforeRegAlloc
}
type defKind byte
const (

4
internal/engine/wazevo/backend/isa/arm64/machine_regalloc.go
View File

@@ -167,7 +167,7 @@ func (pos *labelPosition) InstrIteratorNext() *instruction {
pos.cur = instr
if instr == nil {
return nil
} else if instr.AddedBeforeRegAlloc() {
} else if instr.addedBeforeRegAlloc {
// Only concerned about the instruction added before regalloc.
return instr
}
@@ -190,7 +190,7 @@ func (pos *labelPosition) InstrRevIteratorNext() *instruction {
pos.cur = instr
if instr == nil {
return nil
} else if instr.AddedBeforeRegAlloc() {
} else if instr.addedBeforeRegAlloc {
// Only concerned about the instruction added before regalloc.
return instr
}

2
internal/engine/wazevo/backend/regalloc/api.go
View File

@@ -120,7 +120,5 @@ type (
IsIndirectCall() bool
// IsReturn returns true if this instruction is a return instruction.
IsReturn() bool
// AddedBeforeRegAlloc returns true if this instruction is added before register allocation.
AddedBeforeRegAlloc() bool
}
)

3
internal/engine/wazevo/backend/regalloc/api_test.go
View File

@@ -266,9 +266,6 @@ func (m *mockInstr) Defs(ret *[]VReg) []VReg {
return *ret
}
// AddedBeforeRegAlloc implements Instr.
func (m *mockInstr) AddedBeforeRegAlloc() bool { return true }
// Uses implements Instr.
func (m *mockInstr) Uses(ret *[]VReg) []VReg {
*ret = append((*ret)[:0], m.uses...)