Removes context parameter from instruction-scoped operations (#923)
We originally had a `context.Context` for anything that might be traced, but it turned out to be only useful for lifecycle and host functions. For instruction-scoped aspects like memory updates, a context parameter is too fine-grained and also invisible in practice. For example, most users will use the compiler engine, and its memory, global or table access will never use go's context. Signed-off-by: Adrian Cole <adrian@tetrate.io>
This commit is contained in:
@@ -492,7 +492,7 @@ func Run(t *testing.T, testDataFS embed.FS, ctx context.Context, newEngine func(
|
||||
expType = wasm.ValueTypeF64
|
||||
}
|
||||
require.Equal(t, expType, global.Type(), msg)
|
||||
require.Equal(t, exps[0], global.Get(ctx), msg)
|
||||
require.Equal(t, exps[0], global.Get(), msg)
|
||||
default:
|
||||
t.Fatalf("unsupported action type type: %v", c)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user