hunting bug in delete code

kind/kind.go

@@ -12,6 +12,7 @@ import (
 	"realy.lol/chk"
 	"realy.lol/ints"
 	"realy.lol/log"
+	"realy.lol/lol"
 )
 
 const Len = 2
@@ -127,6 +128,10 @@ func GetString(t *T) string {
 // IsEphemeral returns true if the event kind is an ephemeral event. (not to be
 // stored)
 func (k *T) IsEphemeral() bool {
+	if k == nil {
+		log.I.F("caller provided nil kind %v", lol.GetNLoc(4))
+		return false
+	}
 	return k.K >= EphemeralStart.K && k.K < EphemeralEnd.K
 }
 
@@ -134,6 +139,10 @@ func (k *T) IsEphemeral() bool {
 // if the newest version is the one that is in force (eg follow lists, relay
 // lists, etc.
 func (k *T) IsReplaceable() bool {
+	if k == nil {
+		log.I.F("caller provided nil kind %v", lol.GetNLoc(4))
+		return false
+	}
 	return k.K == ProfileMetadata.K || k.K == FollowList.K ||
 		(k.K >= ReplaceableStart.K && k.K < ReplaceableEnd.K)
 }
@@ -141,6 +150,10 @@ func (k *T) IsReplaceable() bool {
 // IsParameterizedReplaceable is a kind of event that is one of a group of
 // events that replaces based on matching criteria.
 func (k *T) IsParameterizedReplaceable() bool {
+	if k == nil {
+		log.I.F("caller provided nil kind %v", lol.GetNLoc(4))
+		return false
+	}
 	log.I.S(k)
 	return k.K >= ParameterizedReplaceableStart.K &&
 		k.K < ParameterizedReplaceableEnd.K
@@ -163,6 +176,10 @@ var Directory = []*T{
 // IsDirectoryEvent returns whether an event kind is a Directory event, which
 // should grant permission to read such events without requiring authentication.
 func (k *T) IsDirectoryEvent() bool {
+	if k == nil {
+		log.I.F("caller provided nil kind %v", lol.GetNLoc(4))
+		return false
+	}
 	for i := range Directory {
 		if k.Equal(Directory[i]) {
 			return true
@@ -197,6 +214,10 @@ var Text = []*T{
 }
 
 func (k *T) IsText() bool {
+	if k == nil {
+		log.I.F("caller provided nil kind %v", lol.GetNLoc(4))
+		return false
+	}
 	for i := range Text {
 		if k.Equal(Text[i]) {
 			return true

realy/acceptevent.go

@@ -74,6 +74,10 @@ func (s *Server) acceptEvent(c context.T, evt *event.T, authedPubkey []byte,
 					log.I.S("remainder", evt, rem)
 				}
 				log.I.S(a)
+				if a.Kind == nil {
+					log.I.F("a tag is empty!")
+					continue
+				}
 				if a.Kind.Equal(kind.Deletion) {
 					// we don't delete delete events, period
 					return false, "delete event kind may not be deleted", nil

tags/tags.go

@@ -176,15 +176,17 @@ func (t *T) GetLast(tagPrefix *tag.T) *tag.T {
 }
 
 // GetAll gets all the tags that match the prefix, see [T.StartsWith]
-func (t *T) GetAll(tagPrefix *tag.T) *T {
+func (t *T) GetAll(tagPrefix *tag.T) (result *T) {
 	// log.I.S("GetAll", tagPrefix, t)
-	result := &T{element: make([]*tag.T, 0, len(t.element))}
 	for _, v := range t.element {
 		if v.StartsWith(tagPrefix) {
+			if result == nil {
+				result = &T{element: make([]*tag.T, 0, len(t.element))}
+			}
 			result.element = append(result.element, v)
 		}
 	}
-	return result
+	return
 }
 
 // FilterOut removes all tags that match the prefix, see [T.StartsWith]