mleku/plebeian-signer
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

bug with approve not working #2

New Issue
Open
opened 2025-12-19 20:13:09 +00:00 by mleku · 1 comment
mleku commented 2025-12-19 20:13:09 +00:00
Owner
Copy Link

there are often cases where it pops up a permission request and the approve button does nothing, and doesn't make the popup go away. this is a pre-existing bug from gooti, it needs to be fixed asap.

there are often cases where it pops up a permission request and the approve button does nothing, and doesn't make the popup go away. this is a pre-existing bug from gooti, it needs to be fixed asap.
mleku commented 2025-12-20 08:00:12 +00:00
Author
Owner
Copy Link

this was caused by the Buffer polyfill which was racing with the signer and failing to access the buffer.

Release v1.0.2 - Fix Buffer polyfill race condition in prompt

Browse Source

  • Fix race condition where permission prompts failed on first request
    due to Buffer polyfill not being initialized during module evaluation
  • Replace Buffer.from() with native browser APIs (atob + TextDecoder)
    in prompt.ts for reliable base64 decoding
  • Add debug logging to reckless mode approval checks
  • Update permission encryption to support v2 vault key format
  • Enhance LoggerService with warn/error/debug methods and log storage
  • Add logs component for viewing extension activity
  • Simplify deriving modal component
  • Rename icon files from gooti to plebian-signer
  • Update permissions component with improved styling

Files modified:

  • projects/chrome/src/prompt.ts
  • projects/firefox/src/prompt.ts
  • projects/*/src/background-common.ts
  • projects/common/src/lib/services/logger/logger.service.ts
  • projects/*/src/app/components/home/logs/ (new)
  • projects//public/.svg, *.png (renamed)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com

this was caused by the Buffer polyfill which was racing with the signer and failing to access the buffer. Release v1.0.2 - Fix Buffer polyfill race condition in prompt Browse Source - Fix race condition where permission prompts failed on first request due to Buffer polyfill not being initialized during module evaluation - Replace Buffer.from() with native browser APIs (atob + TextDecoder) in prompt.ts for reliable base64 decoding - Add debug logging to reckless mode approval checks - Update permission encryption to support v2 vault key format - Enhance LoggerService with warn/error/debug methods and log storage - Add logs component for viewing extension activity - Simplify deriving modal component - Rename icon files from gooti to plebian-signer - Update permissions component with improved styling Files modified: - projects/chrome/src/prompt.ts - projects/firefox/src/prompt.ts - projects/*/src/background-common.ts - projects/common/src/lib/services/logger/logger.service.ts - projects/*/src/app/components/home/logs/ (new) - projects/*/public/*.svg, *.png (renamed) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
mleku
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mleku/plebeian-signer#2
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?