mleku
f8a321eaee
Some checks failed
Go / build (push) Has been cancelled
- Introduced `startTime` field in `Listener` to log connection duration. - Enhanced diagnostics with detailed connection statistics on close. - Improved logging and error handling for PING/PONG and message lifecycle. - Updated version to v0.8.7.
92 lines
2.5 KiB
Go
92 lines
2.5 KiB
Go
package app
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"time"
|
|
|
|
"github.com/coder/websocket"
|
|
"lol.mleku.dev/chk"
|
|
"lol.mleku.dev/log"
|
|
"next.orly.dev/pkg/utils/atomic"
|
|
)
|
|
|
|
type Listener struct {
|
|
*Server
|
|
conn *websocket.Conn
|
|
ctx context.Context
|
|
remote string
|
|
req *http.Request
|
|
challenge atomic.Bytes
|
|
authedPubkey atomic.Bytes
|
|
startTime time.Time
|
|
// Diagnostics: per-connection counters
|
|
msgCount int
|
|
reqCount int
|
|
eventCount int
|
|
}
|
|
|
|
// Ctx returns the listener's context, but creates a new context for each operation
|
|
// to prevent cancellation from affecting subsequent operations
|
|
func (l *Listener) Ctx() context.Context {
|
|
return l.ctx
|
|
}
|
|
|
|
func (l *Listener) Write(p []byte) (n int, err error) {
|
|
start := time.Now()
|
|
msgLen := len(p)
|
|
|
|
// Log message attempt with content preview (first 200 chars for diagnostics)
|
|
preview := string(p)
|
|
if len(preview) > 200 {
|
|
preview = preview[:200] + "..."
|
|
}
|
|
log.D.F("ws->%s attempting write: len=%d preview=%q", l.remote, msgLen, preview)
|
|
|
|
// Use a separate context with timeout for writes to prevent race conditions
|
|
// where the main connection context gets cancelled while writing events
|
|
writeCtx, cancel := context.WithTimeout(
|
|
context.Background(), DefaultWriteTimeout,
|
|
)
|
|
defer cancel()
|
|
|
|
// Attempt the write operation
|
|
writeStart := time.Now()
|
|
if err = l.conn.Write(writeCtx, websocket.MessageText, p); err != nil {
|
|
writeDuration := time.Since(writeStart)
|
|
totalDuration := time.Since(start)
|
|
|
|
// Log detailed failure information
|
|
log.E.F("ws->%s WRITE FAILED: len=%d duration=%v write_duration=%v error=%v preview=%q",
|
|
l.remote, msgLen, totalDuration, writeDuration, err, preview)
|
|
|
|
// Check if this is a context timeout
|
|
if writeCtx.Err() != nil {
|
|
log.E.F("ws->%s write timeout after %v (limit=%v)", l.remote, writeDuration, DefaultWriteTimeout)
|
|
}
|
|
|
|
// Check connection state
|
|
if l.conn != nil {
|
|
log.D.F("ws->%s connection state during failure: remote_addr=%v", l.remote, l.req.RemoteAddr)
|
|
}
|
|
|
|
chk.E(err) // Still call the original error handler
|
|
return
|
|
}
|
|
|
|
// Log successful write with timing
|
|
writeDuration := time.Since(writeStart)
|
|
totalDuration := time.Since(start)
|
|
n = msgLen
|
|
|
|
log.D.F("ws->%s WRITE SUCCESS: len=%d duration=%v write_duration=%v",
|
|
l.remote, n, totalDuration, writeDuration)
|
|
|
|
// Log slow writes for performance diagnostics
|
|
if writeDuration > time.Millisecond*100 {
|
|
log.D.F("ws->%s SLOW WRITE detected: %v (>100ms) len=%d", l.remote, writeDuration, n)
|
|
}
|
|
|
|
return
|
|
}
|