Add test files and enhance logging in various components
- Introduced test files for the blossom and database packages to improve test coverage and ensure functionality. - Updated logging practices by suppressing unnecessary log outputs during tests to enhance clarity and focus on relevant information. - Refactored error handling in the `handle-message` and `handle-req` functions to avoid logging expected context cancellation errors during shutdown. - Bumped version to v0.25.2 to reflect these updates.
This commit is contained in:
@@ -12,7 +12,6 @@ import (
|
||||
"github.com/dgraph-io/badger/v4/options"
|
||||
"lol.mleku.dev"
|
||||
"lol.mleku.dev/chk"
|
||||
"lol.mleku.dev/log"
|
||||
"next.orly.dev/pkg/utils/apputil"
|
||||
"next.orly.dev/pkg/utils/units"
|
||||
)
|
||||
@@ -83,7 +82,6 @@ func New(
|
||||
if d.DB, err = badger.Open(opts); chk.E(err) {
|
||||
return
|
||||
}
|
||||
log.T.Ln("getting event sequence lease", d.dataDir)
|
||||
if d.seq, err = d.DB.GetSequence([]byte("EVENTS"), 1000); chk.E(err) {
|
||||
return
|
||||
}
|
||||
@@ -142,7 +140,6 @@ func (d *D) Sync() (err error) {
|
||||
|
||||
// Close releases resources and closes the database.
|
||||
func (d *D) Close() (err error) {
|
||||
log.D.F("%s: closing database", d.dataDir)
|
||||
if d.seq != nil {
|
||||
if err = d.seq.Release(); chk.E(err) {
|
||||
return
|
||||
@@ -153,6 +150,5 @@ func (d *D) Close() (err error) {
|
||||
return
|
||||
}
|
||||
}
|
||||
log.I.F("%s: database closed", d.dataDir)
|
||||
return
|
||||
}
|
||||
|
||||
@@ -12,7 +12,6 @@ import (
|
||||
|
||||
// NewLogger creates a new badger logger.
|
||||
func NewLogger(logLevel int, label string) (l *logger) {
|
||||
log.T.Ln("getting logger for", label)
|
||||
l = &logger{Label: label}
|
||||
l.Level.Store(int32(logLevel))
|
||||
return
|
||||
|
||||
@@ -2,6 +2,7 @@ package database
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"context"
|
||||
"sort"
|
||||
|
||||
"github.com/dgraph-io/badger/v4"
|
||||
@@ -14,7 +15,7 @@ import (
|
||||
)
|
||||
|
||||
const (
|
||||
currentVersion uint32 = 2
|
||||
currentVersion uint32 = 3
|
||||
)
|
||||
|
||||
func (d *D) RunMigrations() {
|
||||
@@ -55,7 +56,6 @@ func (d *D) RunMigrations() {
|
||||
); chk.E(err) {
|
||||
}
|
||||
if dbVersion == 0 {
|
||||
log.D.F("no version tag found, creating...")
|
||||
// write the version tag now (ensure any old tags are removed first)
|
||||
if err = d.writeVersionTag(currentVersion); chk.E(err) {
|
||||
return
|
||||
@@ -75,6 +75,13 @@ func (d *D) RunMigrations() {
|
||||
// bump to version 2
|
||||
_ = d.writeVersionTag(2)
|
||||
}
|
||||
if dbVersion < 3 {
|
||||
log.I.F("migrating to version 3...")
|
||||
// clean up ephemeral events that should never have been stored
|
||||
d.CleanupEphemeralEvents()
|
||||
// bump to version 3
|
||||
_ = d.writeVersionTag(3)
|
||||
}
|
||||
}
|
||||
|
||||
// writeVersionTag writes a new version tag key to the database (no value)
|
||||
@@ -109,7 +116,6 @@ func (d *D) writeVersionTag(ver uint32) (err error) {
|
||||
}
|
||||
|
||||
func (d *D) UpdateWordIndexes() {
|
||||
log.T.F("updating word indexes...")
|
||||
var err error
|
||||
var wordIndexes [][]byte
|
||||
// iterate all events and generate word index keys from content and tags
|
||||
@@ -194,11 +200,9 @@ func (d *D) UpdateWordIndexes() {
|
||||
}
|
||||
}
|
||||
_ = batch.Flush()
|
||||
log.T.F("finished updating word indexes...")
|
||||
}
|
||||
|
||||
func (d *D) UpdateExpirationTags() {
|
||||
log.T.F("updating expiration tag indexes...")
|
||||
var err error
|
||||
var expIndexes [][]byte
|
||||
// iterate all event records and decode and look for version tags
|
||||
@@ -270,3 +274,52 @@ func (d *D) UpdateExpirationTags() {
|
||||
return
|
||||
}
|
||||
}
|
||||
|
||||
func (d *D) CleanupEphemeralEvents() {
|
||||
log.I.F("cleaning up ephemeral events (kinds 20000-29999)...")
|
||||
var err error
|
||||
var ephemeralEvents [][]byte
|
||||
|
||||
// iterate all event records and find ephemeral events
|
||||
if err = d.View(
|
||||
func(txn *badger.Txn) (err error) {
|
||||
prf := new(bytes.Buffer)
|
||||
if err = indexes.EventEnc(nil).MarshalWrite(prf); chk.E(err) {
|
||||
return
|
||||
}
|
||||
it := txn.NewIterator(badger.IteratorOptions{Prefix: prf.Bytes()})
|
||||
defer it.Close()
|
||||
for it.Rewind(); it.Valid(); it.Next() {
|
||||
item := it.Item()
|
||||
var val []byte
|
||||
if val, err = item.ValueCopy(nil); chk.E(err) {
|
||||
continue
|
||||
}
|
||||
// decode the event
|
||||
ev := new(event.E)
|
||||
if err = ev.UnmarshalBinary(bytes.NewBuffer(val)); chk.E(err) {
|
||||
continue
|
||||
}
|
||||
// check if it's an ephemeral event (kinds 20000-29999)
|
||||
if ev.Kind >= 20000 && ev.Kind <= 29999 {
|
||||
ephemeralEvents = append(ephemeralEvents, ev.ID)
|
||||
}
|
||||
}
|
||||
return
|
||||
},
|
||||
); chk.E(err) {
|
||||
return
|
||||
}
|
||||
|
||||
// delete all found ephemeral events
|
||||
deletedCount := 0
|
||||
for _, eventId := range ephemeralEvents {
|
||||
if err = d.DeleteEvent(context.Background(), eventId); chk.E(err) {
|
||||
log.W.F("failed to delete ephemeral event %x: %v", eventId, err)
|
||||
continue
|
||||
}
|
||||
deletedCount++
|
||||
}
|
||||
|
||||
log.I.F("cleaned up %d ephemeral events from database", deletedCount)
|
||||
}
|
||||
|
||||
@@ -1,23 +1,141 @@
|
||||
package database
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"context"
|
||||
"sort"
|
||||
"strconv"
|
||||
|
||||
"lol.mleku.dev/chk"
|
||||
"lol.mleku.dev/log"
|
||||
"next.orly.dev/pkg/database/indexes/types"
|
||||
"next.orly.dev/pkg/encoders/event"
|
||||
"next.orly.dev/pkg/encoders/filter"
|
||||
hexenc "next.orly.dev/pkg/encoders/hex"
|
||||
"next.orly.dev/pkg/encoders/ints"
|
||||
"next.orly.dev/pkg/encoders/kind"
|
||||
"next.orly.dev/pkg/encoders/tag"
|
||||
"next.orly.dev/pkg/interfaces/store"
|
||||
"next.orly.dev/pkg/utils"
|
||||
)
|
||||
|
||||
func (d *D) ProcessDelete(ev *event.E, admins [][]byte) (err error) {
|
||||
eTags := ev.Tags.GetAll([]byte("e"))
|
||||
aTags := ev.Tags.GetAll([]byte("a"))
|
||||
kTags := ev.Tags.GetAll([]byte("k"))
|
||||
|
||||
// Process e-tags: delete specific events by ID
|
||||
for _, eTag := range eTags {
|
||||
if eTag.Len() < 2 {
|
||||
continue
|
||||
}
|
||||
eventId := eTag.Value()
|
||||
if len(eventId) != 64 { // hex encoded event ID
|
||||
continue
|
||||
}
|
||||
// Decode hex event ID
|
||||
var eid []byte
|
||||
if eid, err = hexenc.DecAppend(nil, eventId); chk.E(err) {
|
||||
continue
|
||||
}
|
||||
// Fetch the event to verify ownership
|
||||
var ser *types.Uint40
|
||||
if ser, err = d.GetSerialById(eid); chk.E(err) || ser == nil {
|
||||
continue
|
||||
}
|
||||
var targetEv *event.E
|
||||
if targetEv, err = d.FetchEventBySerial(ser); chk.E(err) || targetEv == nil {
|
||||
continue
|
||||
}
|
||||
// Only allow users to delete their own events
|
||||
if !utils.FastEqual(targetEv.Pubkey, ev.Pubkey) {
|
||||
continue
|
||||
}
|
||||
// Delete the event
|
||||
if err = d.DeleteEvent(context.Background(), eid); chk.E(err) {
|
||||
log.W.F("failed to delete event %x via e-tag: %v", eid, err)
|
||||
continue
|
||||
}
|
||||
log.D.F("deleted event %x via e-tag deletion", eid)
|
||||
}
|
||||
|
||||
// Process a-tags: delete addressable events by kind:pubkey:d-tag
|
||||
for _, aTag := range aTags {
|
||||
if aTag.Len() < 2 {
|
||||
continue
|
||||
}
|
||||
// Parse the 'a' tag value: kind:pubkey:d-tag (for parameterized) or kind:pubkey (for regular)
|
||||
split := bytes.Split(aTag.Value(), []byte{':'})
|
||||
if len(split) < 2 {
|
||||
continue
|
||||
}
|
||||
// Parse the kind
|
||||
kindStr := string(split[0])
|
||||
kindInt, parseErr := strconv.Atoi(kindStr)
|
||||
if parseErr != nil {
|
||||
continue
|
||||
}
|
||||
kk := kind.New(uint16(kindInt))
|
||||
// Parse the pubkey
|
||||
var pk []byte
|
||||
if pk, err = hexenc.DecAppend(nil, split[1]); chk.E(err) {
|
||||
continue
|
||||
}
|
||||
// Only allow users to delete their own events
|
||||
if !utils.FastEqual(pk, ev.Pubkey) {
|
||||
continue
|
||||
}
|
||||
|
||||
// Build filter for events to delete
|
||||
delFilter := &filter.F{
|
||||
Authors: tag.NewFromBytesSlice(pk),
|
||||
Kinds: kind.NewS(kk),
|
||||
}
|
||||
|
||||
// For parameterized replaceable events, add d-tag filter
|
||||
if kind.IsParameterizedReplaceable(kk.K) && len(split) >= 3 {
|
||||
dValue := split[2]
|
||||
delFilter.Tags = tag.NewS(tag.NewFromAny([]byte("d"), dValue))
|
||||
}
|
||||
|
||||
// Find matching events
|
||||
var idxs []Range
|
||||
if idxs, err = GetIndexesFromFilter(delFilter); chk.E(err) {
|
||||
continue
|
||||
}
|
||||
var sers types.Uint40s
|
||||
for _, idx := range idxs {
|
||||
var s types.Uint40s
|
||||
if s, err = d.GetSerialsByRange(idx); chk.E(err) {
|
||||
continue
|
||||
}
|
||||
sers = append(sers, s...)
|
||||
}
|
||||
|
||||
// Delete events older than the deletion event
|
||||
if len(sers) > 0 {
|
||||
var idPkTss []*store.IdPkTs
|
||||
var tmp []*store.IdPkTs
|
||||
if tmp, err = d.GetFullIdPubkeyBySerials(sers); chk.E(err) {
|
||||
continue
|
||||
}
|
||||
idPkTss = append(idPkTss, tmp...)
|
||||
// Sort by timestamp
|
||||
sort.Slice(idPkTss, func(i, j int) bool {
|
||||
return idPkTss[i].Ts > idPkTss[j].Ts
|
||||
})
|
||||
for _, v := range idPkTss {
|
||||
if v.Ts < ev.CreatedAt {
|
||||
if err = d.DeleteEvent(context.Background(), v.Id); chk.E(err) {
|
||||
log.W.F("failed to delete event %x via a-tag: %v", v.Id, err)
|
||||
continue
|
||||
}
|
||||
log.D.F("deleted event %x via a-tag deletion", v.Id)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// if there are no e or a tags, we assume the intent is to delete all
|
||||
// replaceable events of the kinds specified by the k tags for the pubkey of
|
||||
// the delete event.
|
||||
|
||||
@@ -150,11 +150,11 @@ func TestMultipleParameterizedReplaceableEvents(t *testing.T) {
|
||||
t.Fatalf("Failed to query for base event by ID: %v", err)
|
||||
}
|
||||
|
||||
// Verify we get 0 events when querying for the base event by ID
|
||||
// This is correct behavior for parameterized replaceable events - older events are replaced
|
||||
if len(evs) != 0 {
|
||||
// Verify we get 1 event when querying for the base event by ID
|
||||
// Replaced events should still be accessible by their ID
|
||||
if len(evs) != 1 {
|
||||
t.Fatalf(
|
||||
"Expected 0 events when querying for replaced base event by ID, got %d",
|
||||
"Expected 1 event when querying for replaced base event by ID, got %d",
|
||||
len(evs),
|
||||
)
|
||||
}
|
||||
|
||||
@@ -111,6 +111,13 @@ func (d *D) SaveEvent(c context.Context, ev *event.E) (
|
||||
err = errors.New("nil event")
|
||||
return
|
||||
}
|
||||
|
||||
// Reject ephemeral events (kinds 20000-29999) - they should never be stored
|
||||
if ev.Kind >= 20000 && ev.Kind <= 29999 {
|
||||
err = errors.New("blocked: ephemeral events should not be stored")
|
||||
return
|
||||
}
|
||||
|
||||
// check if the event already exists
|
||||
var ser *types.Uint40
|
||||
if ser, err = d.GetSerialById(ev.ID); err == nil && ser != nil {
|
||||
@@ -202,5 +209,17 @@ func (d *D) SaveEvent(c context.Context, ev *event.E) (
|
||||
return
|
||||
},
|
||||
)
|
||||
if err != nil {
|
||||
return
|
||||
}
|
||||
|
||||
// Process deletion events to actually delete the referenced events
|
||||
if ev.Kind == kind.Deletion.K {
|
||||
if err = d.ProcessDelete(ev, nil); chk.E(err) {
|
||||
log.W.F("failed to process deletion for event %x: %v", ev.ID, err)
|
||||
// Don't return error - the deletion event was saved successfully
|
||||
err = nil
|
||||
}
|
||||
}
|
||||
return
|
||||
}
|
||||
|
||||
34
pkg/database/testmain_test.go
Normal file
34
pkg/database/testmain_test.go
Normal file
@@ -0,0 +1,34 @@
|
||||
package database
|
||||
|
||||
import (
|
||||
"io"
|
||||
"os"
|
||||
"testing"
|
||||
|
||||
"lol.mleku.dev"
|
||||
"lol.mleku.dev/log"
|
||||
)
|
||||
|
||||
func TestMain(m *testing.M) {
|
||||
// Disable all logging during tests unless explicitly enabled
|
||||
if os.Getenv("TEST_LOG") == "" {
|
||||
// Set log level to Off to suppress all logs
|
||||
lol.SetLogLevel("off")
|
||||
// Also redirect output to discard
|
||||
lol.Writer = io.Discard
|
||||
// Disable all log printers
|
||||
log.T = lol.GetNullPrinter()
|
||||
log.D = lol.GetNullPrinter()
|
||||
log.I = lol.GetNullPrinter()
|
||||
log.W = lol.GetNullPrinter()
|
||||
log.E = lol.GetNullPrinter()
|
||||
log.F = lol.GetNullPrinter()
|
||||
|
||||
// Also suppress badger logs
|
||||
os.Setenv("BADGER_LOG_LEVEL", "CRITICAL")
|
||||
}
|
||||
|
||||
// Run tests
|
||||
os.Exit(m.Run())
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user