Refactor crypto package to use p256k1 signer

- Replaced the p256k package with p256k1.mleku.dev/signer across the codebase, updating all instances where the previous signer was utilized.
- Removed the deprecated p256k package, including all related files and tests, to streamline the codebase and improve maintainability.
- Updated various components, including event handling, database interactions, and protocol implementations, to ensure compatibility with the new signer interface.
- Enhanced tests to validate the new signing functionality and ensure robustness across the application.
- Bumped version to v0.23.3 to reflect these changes.

app/handle-relayinfo.go

@@ -9,7 +9,7 @@ import (
 	"lol.mleku.dev/chk"
 	"lol.mleku.dev/log"
 	"next.orly.dev/pkg/acl"
-	"next.orly.dev/pkg/crypto/p256k"
+	p256k1signer "p256k1.mleku.dev/signer"
 	"next.orly.dev/pkg/encoders/hex"
 	"next.orly.dev/pkg/protocol/relayinfo"
 	"next.orly.dev/pkg/version"
@@ -74,7 +74,7 @@ func (s *Server) HandleRelayInfo(w http.ResponseWriter, r *http.Request) {
 	// Get relay identity pubkey as hex
 	var relayPubkey string
 	if skb, err := s.D.GetRelayIdentitySecret(); err == nil && len(skb) == 32 {
-		sign := new(p256k.Signer)
+		sign := p256k1signer.NewP256K1Signer()
 		if err := sign.InitSec(skb); err == nil {
 			relayPubkey = hex.Enc(sign.Pub())
 		}

app/listener.go

@@ -49,13 +49,37 @@ func (l *Listener) Ctx() context.Context {
 // writeWorker is the single goroutine that handles all writes to the websocket connection.
 // This serializes all writes to prevent concurrent write panics.
 func (l *Listener) writeWorker() {
-	defer close(l.writeDone)
+	var channelClosed bool
+	defer func() {
+		// Only unregister write channel if connection is actually dead/closing
+		// Unregister if:
+		// 1. Context is cancelled (connection closing)
+		// 2. Channel was closed (connection closing)
+		// 3. Connection error occurred (already handled inline)
+		if l.ctx.Err() != nil || channelClosed {
+			// Connection is closing - safe to unregister
+			if socketPub := l.publishers.GetSocketPublisher(); socketPub != nil {
+				log.D.F("ws->%s write worker: unregistering write channel (connection closing)", l.remote)
+				socketPub.SetWriteChan(l.conn, nil)
+			}
+		} else {
+			// Exiting for other reasons (timeout, etc.) but connection may still be alive
+			// Don't unregister - let the connection cleanup handle it
+			log.D.F("ws->%s write worker: exiting but connection may still be alive, keeping write channel registered", l.remote)
+		}
+		close(l.writeDone)
+	}()
 	for {
 		select {
 		case <-l.ctx.Done():
+			// Context cancelled - connection is closing
+			log.D.F("ws->%s write worker: context cancelled, exiting", l.remote)
 			return
 		case req, ok := <-l.writeChan:
 			if !ok {
+				// Channel closed - connection is closing
+				channelClosed = true
+				log.D.F("ws->%s write worker: write channel closed, exiting", l.remote)
 				return
 			}
 			deadline := req.Deadline
@@ -82,9 +106,15 @@ func (l *Listener) writeWorker() {
 						websocket.CloseGoingAway,
 						websocket.CloseNoStatusReceived)
 				if isConnectionError {
+					// Connection is dead - unregister channel immediately
+					log.D.F("ws->%s write worker: connection error detected, unregistering write channel", l.remote)
+					if socketPub := l.publishers.GetSocketPublisher(); socketPub != nil {
+						socketPub.SetWriteChan(l.conn, nil)
+					}
 					return
 				}
-				// Continue for other errors (timeouts, etc.)
+				// Continue for other errors (timeouts, etc.) - connection may still be alive
+				log.D.F("ws->%s write worker: non-fatal error (timeout?), continuing", l.remote)
 			} else {
 				writeDuration := time.Since(writeStart)
 				if writeDuration > time.Millisecond*100 {

app/main.go

@@ -161,7 +161,7 @@ func Run(
 	}
 
 	if l.paymentProcessor, err = NewPaymentProcessor(ctx, cfg, db); err != nil {
-		log.E.F("failed to create payment processor: %v", err)
+		// log.E.F("failed to create payment processor: %v", err)
 		// Continue without payment processor
 	} else {
 		if err = l.paymentProcessor.Start(); err != nil {

app/payment_processor.go

@@ -15,7 +15,7 @@ import (
 	"lol.mleku.dev/log"
 	"next.orly.dev/app/config"
 	"next.orly.dev/pkg/acl"
-	"next.orly.dev/pkg/crypto/p256k"
+	p256k1signer "p256k1.mleku.dev/signer"
 	"next.orly.dev/pkg/database"
 	"next.orly.dev/pkg/encoders/bech32encoding"
 	"next.orly.dev/pkg/encoders/event"
@@ -152,7 +152,7 @@ func (pp *PaymentProcessor) syncFollowList() error {
 		return err
 	}
 	// signer
-	sign := new(p256k.Signer)
+	sign := p256k1signer.NewP256K1Signer()
 	if err := sign.InitSec(skb); err != nil {
 		return err
 	}
@@ -272,7 +272,7 @@ func (pp *PaymentProcessor) createExpiryWarningNote(
 	}
 
 	// Initialize signer
-	sign := new(p256k.Signer)
+	sign := p256k1signer.NewP256K1Signer()
 	if err := sign.InitSec(skb); err != nil {
 		return fmt.Errorf("failed to initialize signer: %w", err)
 	}
@@ -383,7 +383,7 @@ func (pp *PaymentProcessor) createTrialReminderNote(
 	}
 
 	// Initialize signer
-	sign := new(p256k.Signer)
+	sign := p256k1signer.NewP256K1Signer()
 	if err := sign.InitSec(skb); err != nil {
 		return fmt.Errorf("failed to initialize signer: %w", err)
 	}
@@ -530,7 +530,7 @@ func (pp *PaymentProcessor) handleNotification(
 		if s, ok := metadata["relay_pubkey"].(string); ok && s != "" {
 			if rpk, err := decodeAnyPubkey(s); err == nil {
 				if skb, err := pp.db.GetRelayIdentitySecret(); err == nil && len(skb) == 32 {
-					var signer p256k.Signer
+					signer := p256k1signer.NewP256K1Signer()
 					if err := signer.InitSec(skb); err == nil {
 						if !strings.EqualFold(
 							hex.Enc(rpk), hex.Enc(signer.Pub()),
@@ -644,7 +644,7 @@ func (pp *PaymentProcessor) createPaymentNote(
 	}
 
 	// Initialize signer
-	sign := new(p256k.Signer)
+	sign := p256k1signer.NewP256K1Signer()
 	if err := sign.InitSec(skb); err != nil {
 		return fmt.Errorf("failed to initialize signer: %w", err)
 	}
@@ -738,7 +738,7 @@ func (pp *PaymentProcessor) CreateWelcomeNote(userPubkey []byte) error {
 	}
 
 	// Initialize signer
-	sign := new(p256k.Signer)
+	sign := p256k1signer.NewP256K1Signer()
 	if err := sign.InitSec(skb); err != nil {
 		return fmt.Errorf("failed to initialize signer: %w", err)
 	}
@@ -1025,7 +1025,7 @@ func (pp *PaymentProcessor) UpdateRelayProfile() error {
 	}
 
 	// Initialize signer
-	sign := new(p256k.Signer)
+	sign := p256k1signer.NewP256K1Signer()
 	if err := sign.InitSec(skb); err != nil {
 		return fmt.Errorf("failed to initialize signer: %w", err)
 	}

app/publisher.go

@@ -89,10 +89,15 @@ func NewPublisher(c context.Context) (publisher *P) {
 func (p *P) Type() (typeName string) { return Type }
 
 // SetWriteChan stores the write channel for a websocket connection
+// If writeChan is nil, the entry is removed from the map
 func (p *P) SetWriteChan(conn *websocket.Conn, writeChan chan<- publish.WriteRequest) {
 	p.Mx.Lock()
 	defer p.Mx.Unlock()
-	p.WriteChans[conn] = writeChan
+	if writeChan == nil {
+		delete(p.WriteChans, conn)
+	} else {
+		p.WriteChans[conn] = writeChan
+	}
 }
 
 // GetWriteChan returns the write channel for a websocket connection
@@ -340,7 +345,9 @@ func (p *P) removeSubscriberId(ws *websocket.Conn, id string) {
 		// Check the actual map after deletion, not the original reference
 		if len(p.Map[ws]) == 0 {
 			delete(p.Map, ws)
-			delete(p.WriteChans, ws)
+			// Don't remove write channel here - it's tied to the connection, not subscriptions
+			// The write channel will be removed when the connection closes (in handle-websocket.go defer)
+			// This allows new subscriptions to be created on the same connection
 		}
 	}
 }