Decompose handle-event.go into DDD domain services (v0.36.15)

Major refactoring of event handling into clean, testable domain services:

- Add pkg/event/validation: JSON hex validation, signature verification,
  timestamp bounds, NIP-70 protected tag validation
- Add pkg/event/authorization: Policy and ACL authorization decisions,
  auth challenge handling, access level determination
- Add pkg/event/routing: Event router registry with ephemeral and delete
  handlers, kind-based dispatch
- Add pkg/event/processing: Event persistence, delivery to subscribers,
  and post-save hooks (ACL reconfig, sync, relay groups)
- Reduce handle-event.go from 783 to 296 lines (62% reduction)
- Add comprehensive unit tests for all new domain services
- Refactor database tests to use shared TestMain setup
- Fix blossom URL test expectations (missing "/" separator)
- Add go-memory-optimization skill and analysis documentation
- Update DDD_ANALYSIS.md to reflect completed decomposition

Files modified:
- app/handle-event.go: Slim orchestrator using domain services
- app/server.go: Service initialization and interface wrappers
- app/handle-event-types.go: Shared types (OkHelper, result types)
- pkg/event/validation/*: New validation service package
- pkg/event/authorization/*: New authorization service package
- pkg/event/routing/*: New routing service package
- pkg/event/processing/*: New processing service package
- pkg/database/*_test.go: Refactored to shared TestMain
- pkg/blossom/http_test.go: Fixed URL format expectations

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

pkg/database/get-serials-by-range_test.go

@@ -1,109 +1,28 @@
 package database
 
 import (
-	"bufio"
-	"bytes"
-	"context"
-	"os"
-	"sort"
 	"testing"
 
-	"git.mleku.dev/mleku/nostr/encoders/event"
-	"git.mleku.dev/mleku/nostr/encoders/event/examples"
 	"git.mleku.dev/mleku/nostr/encoders/filter"
 	"git.mleku.dev/mleku/nostr/encoders/kind"
 	"git.mleku.dev/mleku/nostr/encoders/tag"
 	"git.mleku.dev/mleku/nostr/encoders/timestamp"
-	"lol.mleku.dev/chk"
-	"next.orly.dev/pkg/database/indexes/types"
 	"next.orly.dev/pkg/utils"
 )
 
 func TestGetSerialsByRange(t *testing.T) {
-	// Create a temporary directory for the database
-	tempDir, err := os.MkdirTemp("", "test-db-*")
-	if err != nil {
-		t.Fatalf("Failed to create temporary directory: %v", err)
+	// Use shared database (skips in short mode)
+	db, _ := GetSharedDB(t)
+	savedEvents := GetSharedEvents(t)
+
+	if len(savedEvents) < 10 {
+		t.Fatalf("Need at least 10 saved events, got %d", len(savedEvents))
 	}
-	defer os.RemoveAll(tempDir) // Clean up after the test
-
-	// Create a context and cancel function for the database
-	ctx, cancel := context.WithCancel(context.Background())
-	defer cancel()
-
-	// Initialize the database
-	db, err := New(ctx, cancel, tempDir, "info")
-	if err != nil {
-		t.Fatalf("Failed to create database: %v", err)
-	}
-	defer db.Close()
-
-	// Create a scanner to read events from examples.Cache
-	scanner := bufio.NewScanner(bytes.NewBuffer(examples.Cache))
-	scanner.Buffer(make([]byte, 0, 1_000_000_000), 1_000_000_000)
-
-	var events []*event.E
-	var eventSerials = make(map[string]*types.Uint40) // Map event ID (hex) to serial
-
-	// First, collect all events from examples.Cache
-	for scanner.Scan() {
-		chk.E(scanner.Err())
-		b := scanner.Bytes()
-		ev := event.New()
-
-		// Unmarshal the event
-		if _, err = ev.Unmarshal(b); chk.E(err) {
-			ev.Free()
-			t.Fatal(err)
-		}
-
-		events = append(events, ev)
-	}
-
-	// Check for scanner errors
-	if err = scanner.Err(); err != nil {
-		t.Fatalf("Scanner error: %v", err)
-	}
-
-	// Sort events by CreatedAt to ensure addressable events are processed in chronological order
-	sort.Slice(events, func(i, j int) bool {
-		return events[i].CreatedAt < events[j].CreatedAt
-	})
-
-	// Count the number of events processed
-	eventCount := 0
-	skippedCount := 0
-
-	// Now process each event in chronological order
-	for _, ev := range events {
-		// Save the event to the database
-		if _, err = db.SaveEvent(ctx, ev); err != nil {
-			// Skip events that fail validation (e.g., kind 3 without p tags)
-			skippedCount++
-			continue
-		}
-
-		// Get the serial for this event
-		serial, err := db.GetSerialById(ev.ID)
-		if err != nil {
-			t.Fatalf(
-				"Failed to get serial for event #%d: %v", eventCount+1, err,
-			)
-		}
-
-		if serial != nil {
-			eventSerials[string(ev.ID)] = serial
-		}
-
-		eventCount++
-	}
-
-	t.Logf("Successfully saved %d events to the database (skipped %d invalid events)", eventCount, skippedCount)
 
 	// Test GetSerialsByRange with a time range filter
 	// Use the timestamp from the middle event as a reference
-	middleIndex := len(events) / 2
-	middleEvent := events[middleIndex]
+	middleIndex := len(savedEvents) / 2
+	middleEvent := savedEvents[middleIndex]
 
 	// Create a timestamp range that includes events before and after the middle event
 	sinceTime := new(timestamp.T)
@@ -202,7 +121,7 @@ func TestGetSerialsByRange(t *testing.T) {
 
 	// Test GetSerialsByRange with an author filter
 	authorFilter := &filter.F{
-		Authors: tag.NewFromBytesSlice(events[1].Pubkey),
+		Authors: tag.NewFromBytesSlice(savedEvents[1].Pubkey),
 	}
 
 	// Get the indexes from the filter
@@ -235,10 +154,10 @@ func TestGetSerialsByRange(t *testing.T) {
 			t.Fatalf("Failed to fetch event for serial %d: %v", i, err)
 		}
 
-		if !utils.FastEqual(ev.Pubkey, events[1].Pubkey) {
+		if !utils.FastEqual(ev.Pubkey, savedEvents[1].Pubkey) {
 			t.Fatalf(
 				"Event %d has incorrect author. Got %x, expected %x",
-				i, ev.Pubkey, events[1].Pubkey,
+				i, ev.Pubkey, savedEvents[1].Pubkey,
 			)
 		}
 	}