mleku/moxa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

style: fix warnings from golangci-lint printed by make check (#11)

Browse Source 
* style: fix warnings from golangci-lint printed by `make check`
* style: err assign in if block when possible. Better use of switch/case
* style: err assign in if block when possible
This commit is contained in:
Marc Vertes
2019-01-16 18:59:24 +01:00
committed by Ludovic Fernandez
parent 7987a97847
commit 098829d316
11 changed files with 103 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
interp/run.go
View File

@@ -423,7 +423,8 @@ func call(n *Node) {
// Copy input parameters from caller
for i, v := range values {
src := v(f)
if method && i == 0 {
switch {
case method && i == 0:
dest := nf.data[def.framepos[i]]
// Accommodate to receiver type
ks, kd := src.Kind(), dest.Kind()
@@ -436,9 +437,9 @@ func call(n *Node) {
} else {
dest.Set(src)
}
} else if variadic >= 0 && i >= variadic {
case variadic >= 0 && i >= variadic:
vararg.Set(reflect.Append(vararg, src))
} else {
default:
nf.data[def.framepos[i]].Set(src)
}
}
@@ -515,7 +516,8 @@ func callBin(n *Node) {
l := len(values)
fsize := n.child[0].fsize
if n.anc.kind == GoStmt {
switch {
case n.anc.kind == GoStmt:
// Execute function in a goroutine, discard results
n.exec = func(f *Frame) Builtin {
in := make([]reflect.Value, l)
@@ -525,7 +527,7 @@ func callBin(n *Node) {
go value(f).Call(in)
return tnext
}
} else if fnext != nil {
case fnext != nil:
// Handle branching according to boolean result
n.exec = func(f *Frame) Builtin {
in := make([]reflect.Value, l)
@@ -538,7 +540,7 @@ func callBin(n *Node) {
}
return fnext
}
} else {
default:
n.exec = func(f *Frame) Builtin {
in := make([]reflect.Value, l)
for i, v := range values {
@@ -1266,6 +1268,7 @@ func clauseChanDir(n *Node) (*Node, *Node, *Node, reflect.SelectDir) {
case Assign:
assigned = m.anc.child[0]
case AssignX:
ok = m.anc.child[1]
// TODO
}
stop = true