Tim Ruffing 214cb3c321 Merge #772: Improve constant-timeness on PowerPC ...

67a429f31f Suppress a harmless variable-time optimization by clang in _int_cmov (Tim Ruffing)
5b196338f0 Remove redundant "? 1 : 0" after comparisons in scalar code (Tim Ruffing)

Pull request description:

  Attempt at resolving #771 .

  This surprisingly seems to improve the situation at least for the compilers available on godbolt.

ACKs for top commit:
  gmaxwell:
    ACK 67a429f31f
  elichai:
    tACK 67a429f31f

Tree-SHA512: ee8b0c86831ec8c3d5a9abcad773ed8a0f267e5c47012e4e1423b10a64c26b4cf6e3c466c3df765ba7e636787a3fe134d633926d67b599287f12c51be924f478

2020-07-28 16:12:24 +02:00

..

asm

Allow field_10x26_arm.s to compile for ARMv7 architecture

2019-05-07 22:37:35 +03:00

modules

Split ecdsa_sign logic into a new function and use it from ecdsa_sign and recovery

2020-06-03 13:19:09 +03:00

basic-config.h

Undef HAVE___INT128 in basic-config.h to fix gen_context compilation

2020-07-21 11:09:23 +02:00

bench_ecdh.c

Pass num of iters to benchmarks as variable, and define envvar

2020-03-13 11:48:01 +02:00

bench_ecmult.c

Pass num of iters to benchmarks as variable, and define envvar

2020-03-13 11:48:01 +02:00

bench_internal.c

Pass num of iters to benchmarks as variable, and define envvar

2020-03-13 11:48:01 +02:00

bench_recover.c

Pass num of iters to benchmarks as variable, and define envvar

2020-03-13 11:48:01 +02:00

bench_sign.c

Pass num of iters to benchmarks as variable, and define envvar

2020-03-13 11:48:01 +02:00

bench_verify.c

Pass num of iters to benchmarks as variable, and define envvar

2020-03-13 11:48:01 +02:00

bench.h

Pass num of iters to benchmarks as variable, and define envvar

2020-03-13 11:48:01 +02:00

ecdsa_impl.h

Make ecdsa_sig_sign constant-time again after reverting 25e3cfb

2020-03-31 15:03:58 +02:00

ecdsa.h

Fix header guards using reserved identifiers

2017-08-26 18:44:21 +03:00

eckey_impl.h

Return 0 if the given seckey is invalid in privkey_negate, privkey_tweak_add and privkey_tweak_mul

2020-03-30 20:51:47 +00:00

eckey.h

Fix header guards using reserved identifiers

2017-08-26 18:44:21 +03:00

ecmult_const_impl.h

Merge #741: Remove unnecessary sign variable from wnaf_const

2020-07-26 12:21:14 +02:00

ecmult_const.h

Add a descriptive comment for secp256k1_ecmult_const.

2019-06-04 01:52:44 +00:00

ecmult_gen_impl.h

Eliminate harmless non-constant time operations on secret data.

2020-02-20 17:27:03 +00:00

ecmult_gen.h

variable signing precompute table

2019-09-05 09:19:41 +02:00

ecmult_impl.h

Remove note about heap allocation in secp256k1_ecmult_odd_multiples_table_storage_var which was removed in 47045270fa

2019-10-28 12:21:36 +00:00

ecmult.h

scratch space: thread error_callback into all scratch space functions

2019-05-25 22:59:50 +00:00

field_5x52_asm_impl.h

Fix header guards using reserved identifiers

2017-08-26 18:44:21 +03:00

field_5x52_impl.h

Add valgrind uninit check to cmovs output

2020-05-26 23:30:56 +03:00

field_5x52_int128_impl.h

Correct math typos in field_*.h

2018-07-06 08:40:35 -04:00

field_5x52.h

Correct math typos in field_*.h

2018-07-06 08:40:35 -04:00

field_10x26_impl.h

Add valgrind uninit check to cmovs output

2020-05-26 23:30:56 +03:00

field_10x26.h

Correct math typos in field_*.h

2018-07-06 08:40:35 -04:00

field_impl.h

Eliminate harmless non-constant time operations on secret data.

2020-02-20 17:27:03 +00:00

field.h

Fixed UB(arithmetics on uninit values) in cmovs

2020-05-22 13:25:26 +03:00

gen_context.c

variable signing precompute table

2019-09-05 09:19:41 +02:00

group_impl.h

Remove secret-dependant non-constant time operation in ecmult_const.

2020-01-09 12:21:28 +00:00

group.h

Fixed UB(arithmetics on uninit values) in cmovs

2020-05-22 13:25:26 +03:00

hash_impl.h

Avoid out-of-bound pointers and integer overflows in size comparisons

2019-05-23 15:22:29 +02:00

hash.h

Get rid of reserved _t in type names

2017-09-27 15:03:20 -07:00

num_gmp_impl.h

Fix header guards using reserved identifiers

2017-08-26 18:44:21 +03:00

num_gmp.h

Fix header guards using reserved identifiers

2017-08-26 18:44:21 +03:00

num_impl.h

Fix header guards using reserved identifiers

2017-08-26 18:44:21 +03:00

num.h

Fix header guards using reserved identifiers

2017-08-26 18:44:21 +03:00

scalar_4x64_impl.h

Remove redundant "? 1 : 0" after comparisons in scalar code

2020-07-26 14:59:56 +02:00

scalar_4x64.h

Fix header guards using reserved identifiers

2017-08-26 18:44:21 +03:00

scalar_8x32_impl.h

Remove redundant "? 1 : 0" after comparisons in scalar code

2020-07-26 14:59:56 +02:00

scalar_8x32.h

Fix header guards using reserved identifiers

2017-08-26 18:44:21 +03:00

scalar_impl.h

Add scalar_set_b32_seckey which does the same as scalar_set_b32 and also returns whether it's a valid secret key

2020-03-30 20:51:47 +00:00

scalar_low_impl.h

Add valgrind uninit check to cmovs output

2020-05-26 23:30:56 +03:00

scalar_low.h

Eliminate harmless non-constant time operations on secret data.

2020-02-20 17:27:03 +00:00

scalar.h

Fixed UB(arithmetics on uninit values) in cmovs

2020-05-22 13:25:26 +03:00

scratch_impl.h

scratch: replace frames with "checkpoint" system

2019-05-26 01:05:09 +00:00

scratch.h

scratch: replace frames with "checkpoint" system

2019-05-26 01:05:09 +00:00

secp256k1.c

Fix some compile problems on weird/old compilers.

2020-07-26 05:26:56 +00:00

testrand_impl.h

Get rid of reserved _t in type names

2017-09-27 15:03:20 -07:00

testrand.h

Fix header guards using reserved identifiers

2017-08-26 18:44:21 +03:00

tests_exhaustive.c

Remove secret-dependant non-constant time operation in ecmult_const.

2020-01-09 12:21:28 +00:00

tests.c

tests: Abort if malloc() fails during context cloning tests

2020-07-28 10:24:44 +02:00

util.h

Suppress a harmless variable-time optimization by clang in _int_cmov

2020-07-27 14:35:05 +02:00

valgrind_ctime_test.c

Add ecdsa_sign_recoverable to the ctime tests

2020-06-03 13:19:11 +03:00