mleku/libbase58
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

b58enc: Allocate buf on the stack rather than heap

Browse Source
This commit is contained in:
Luke Dashjr
2014-08-17 12:04:10 +00:00
parent a2853bb766
commit 7ecd1102d0
1 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
base58.c
View File

@@ -14,7 +14,6 @@
#include <stdbool.h> #include <stdbool.h>
#include <stddef.h> #include <stddef.h>
#include <stdint.h> #include <stdint.h>
#include <stdlib.h>
#include <string.h> #include <string.h>
bool (*b58_sha256_impl)(void *, const void *, size_t) = NULL; bool (*b58_sha256_impl)(void *, const void *, size_t) = NULL;
@@ -124,15 +123,12 @@ bool b58enc(char *b58, size_t *b58sz, const void *data, size_t binsz)
const uint8_t *bin = data; const uint8_t *bin = data;
int i, j, carry, high, zcount = 0; int i, j, carry, high, zcount = 0;
size_t size; size_t size;
uint8_t *buf;
while (zcount < binsz && !bin[zcount]) while (zcount < binsz && !bin[zcount])
++zcount; ++zcount;
size = (binsz - zcount) * 138 / 100 + 1; size = (binsz - zcount) * 138 / 100 + 1;
buf = malloc(size); uint8_t buf[size];
if (!buf)
return false;
memset(buf, 0, size); memset(buf, 0, size);
for (i = zcount, high = size - 1; i < binsz; ++i, high = j) for (i = zcount, high = size - 1; i < binsz; ++i, high = j)
@@ -149,7 +145,6 @@ bool b58enc(char *b58, size_t *b58sz, const void *data, size_t binsz)
if (*b58sz <= zcount + size - j) if (*b58sz <= zcount + size - j)
{ {
free(buf);
*b58sz = zcount + size - j + 1; *b58sz = zcount + size - j + 1;
return false; return false;
} }
@@ -161,6 +156,5 @@ bool b58enc(char *b58, size_t *b58sz, const void *data, size_t binsz)
b58[i] = '\0'; b58[i] = '\0';
*b58sz = i + 1; *b58sz = i + 1;
free(buf);
return true; return true;
} }