1) The guard logic here was inverted, resulting in an always-false
branch, which meant that the suffix after the wildcard was
incorrectly ignored.
2) Wildcards were treated as 1-or-more matches, but git treats them as
0-or-more. This change aligns go-git with git, but represents a bit
of a breaking change for go-git.
Signed-off-by: Mike Lundy <mike@fluffypenguin.org>
Previously, the Src() function was assuming there are no “+” characters in the refspec src
and erroneously used the strings.Index() function to compute the start index of src in the
refspec. This change now uses the IsForceUpdate() method to decide how to elide the
force update token.
Signed-off-by: Alan Cabrera <adc@toolazydogs.com>
- no length for map initialization
- don't check for boolean/error return
- don't format string
- use string method of bytes buffer instead of converting bytes to
string
- use `strings.Contains` instead of `strings.Index`
- use `bytes.Equal` instead of `bytes.Compare`
