From a0fa1278d56569d15d2b5ac3761aa6448f582de4 Mon Sep 17 00:00:00 2001 From: fiatjaf Date: Fri, 24 Nov 2023 17:23:59 -0300 Subject: [PATCH] lmdb: automated migrations. --- lmdb/lib.go | 15 +++++----- lmdb/migration.go | 74 +++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 82 insertions(+), 7 deletions(-) create mode 100644 lmdb/migration.go diff --git a/lmdb/lib.go b/lmdb/lib.go index 7993212..f01f392 100644 --- a/lmdb/lib.go +++ b/lmdb/lib.go @@ -24,6 +24,7 @@ type LMDBBackend struct { lmdbEnv *lmdb.Env + settingsStore lmdb.DBI rawEventStore lmdb.DBI indexCreatedAt lmdb.DBI indexId lmdb.DBI @@ -47,7 +48,7 @@ func (b *LMDBBackend) Init() error { return err } - env.SetMaxDBs(8) + env.SetMaxDBs(9) env.SetMaxReaders(500) env.SetMapSize(1 << 38) // ~273GB @@ -64,16 +65,16 @@ func (b *LMDBBackend) Init() error { // open each db if err := b.lmdbEnv.Update(func(txn *lmdb.Txn) error { + if dbi, err := txn.OpenDBI("settings", lmdb.Create); err != nil { + return err + } else { + b.settingsStore = dbi + } if dbi, err := txn.OpenDBI("raw", lmdb.Create); err != nil { return err } else { b.rawEventStore = dbi - return nil } - }); err != nil { - return err - } - if err := b.lmdbEnv.Update(func(txn *lmdb.Txn) error { if dbi, err := txn.OpenDBI("created_at", lmdb.Create); err != nil { return err } else { @@ -136,7 +137,7 @@ func (b *LMDBBackend) Init() error { return err } - return nil + return b.runMigrations() } func (b *LMDBBackend) Close() { diff --git a/lmdb/migration.go b/lmdb/migration.go new file mode 100644 index 0000000..66f002a --- /dev/null +++ b/lmdb/migration.go @@ -0,0 +1,74 @@ +package lmdb + +import ( + "encoding/binary" + "fmt" + "log" + + "github.com/bmatsuo/lmdb-go/lmdb" +) + +const ( + DB_VERSION byte = 'v' +) + +func (b *LMDBBackend) runMigrations() error { + return b.lmdbEnv.Update(func(txn *lmdb.Txn) error { + var version uint16 + v, err := txn.Get(b.settingsStore, []byte{DB_VERSION}) + if err != nil { + if lmdbErr, ok := err.(*lmdb.OpError); ok && lmdbErr.Errno == lmdb.NotFound { + version = 0 + } else if v == nil { + return fmt.Errorf("failed to read database version: %w", err) + } + } else { + version = binary.BigEndian.Uint16(v) + } + + // do the migrations in increasing steps (there is no rollback) + // + + if version < 1 { + log.Println("migration 1: move all keys from indexTag to indexTag32 if they are 32-bytes") + cursor, err := txn.OpenCursor(b.indexTag) + if err != nil { + return fmt.Errorf("failed to open cursor in migration 1: %w", err) + } + defer cursor.Close() + + key, val, err := cursor.Get(nil, nil, lmdb.First) + for err == nil { + if len(key)-4 /* uint32 created_at */ == 32 { + log.Printf("moving key %x->%x", key, val) + txn.Put(b.indexTag32, key, val, 0) + txn.Del(b.indexTag, key, val) + } + + // next + key, val, err = cursor.Get(nil, nil, lmdb.Next) + } + if lmdbErr, ok := err.(*lmdb.OpError); ok && lmdbErr.Errno != lmdb.NotFound { + // exited the loop with an error different from NOTFOUND + return err + } + + // bump version + if err := b.bumpVersion(txn, 1); err != nil { + return err + } + } + + if version < 2 { + // ... + } + + return nil + }) +} + +func (b *LMDBBackend) bumpVersion(txn *lmdb.Txn, version uint16) error { + buf, err := txn.PutReserve(b.settingsStore, []byte{DB_VERSION}, 4, 0) + binary.BigEndian.PutUint16(buf, version) + return err +}