From 805d134bbb7ca93c0dd16638ef028e6a09af8dce Mon Sep 17 00:00:00 2001 From: fiatjaf Date: Thu, 2 Nov 2023 16:04:08 -0300 Subject: [PATCH] badger: fail completely when a filter has any malformed key or id. --- badger/query.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/badger/query.go b/badger/query.go index 262e7f0..01c3cad 100644 --- a/badger/query.go +++ b/badger/query.go @@ -70,7 +70,6 @@ func (b BadgerBackend) QueryEvents(ctx context.Context, filter nostr.Filter) (ch if err == badger.ErrDiscardedTxn { return } - panic(err) } err = item.Value(func(val []byte) error { @@ -219,7 +218,7 @@ func prepareQueries(filter nostr.Filter) ( for i, pubkeyHex := range filter.Authors { pubkey, _ := hex.DecodeString(pubkeyHex) if len(pubkey) != 32 { - continue + return nil, nil, 0, 0, 0, fmt.Errorf("invalid pubkey '%s'", pubkeyHex) } prefix := make([]byte, 1+32) prefix[0] = index