prevent saving duplicates in badger and lmdb.

This commit is contained in:
fiatjaf
2023-11-06 12:19:02 -03:00
parent da19fdcc10
commit 02e05e2935
3 changed files with 28 additions and 1 deletions

View File

@@ -25,7 +25,6 @@ func (b *BadgerBackend) DeleteEvent(ctx context.Context, evt *nostr.Event) error
it := txn.NewIterator(opts) it := txn.NewIterator(opts)
it.Seek(prefix) it.Seek(prefix)
if it.ValidForPrefix(prefix) { if it.ValidForPrefix(prefix) {
// the key is the last 32 bytes
idx = append(idx, it.Item().Key()[1+32:]...) idx = append(idx, it.Item().Key()[1+32:]...)
} }
it.Close() it.Close()

View File

@@ -2,14 +2,31 @@ package badger
import ( import (
"context" "context"
"encoding/hex"
"github.com/dgraph-io/badger/v4" "github.com/dgraph-io/badger/v4"
"github.com/fiatjaf/eventstore"
"github.com/nbd-wtf/go-nostr" "github.com/nbd-wtf/go-nostr"
nostr_binary "github.com/nbd-wtf/go-nostr/binary" nostr_binary "github.com/nbd-wtf/go-nostr/binary"
) )
func (b *BadgerBackend) SaveEvent(ctx context.Context, evt *nostr.Event) error { func (b *BadgerBackend) SaveEvent(ctx context.Context, evt *nostr.Event) error {
return b.Update(func(txn *badger.Txn) error { return b.Update(func(txn *badger.Txn) error {
// query event by id to ensure we don't save duplicates
id, _ := hex.DecodeString(evt.ID)
prefix := make([]byte, 1+32)
copy(prefix[1:], id)
opts := badger.DefaultIteratorOptions
opts.PrefetchValues = false
it := txn.NewIterator(opts)
defer it.Close()
it.Seek(prefix)
if it.ValidForPrefix(prefix) {
// event exists
return eventstore.ErrDupEvent
}
// encode to binary
bin, err := nostr_binary.Marshal(evt) bin, err := nostr_binary.Marshal(evt)
if err != nil { if err != nil {
return err return err

View File

@@ -2,9 +2,11 @@ package lmdb
import ( import (
"context" "context"
"encoding/hex"
"fmt" "fmt"
"github.com/bmatsuo/lmdb-go/lmdb" "github.com/bmatsuo/lmdb-go/lmdb"
"github.com/fiatjaf/eventstore"
"github.com/nbd-wtf/go-nostr" "github.com/nbd-wtf/go-nostr"
nostr_binary "github.com/nbd-wtf/go-nostr/binary" nostr_binary "github.com/nbd-wtf/go-nostr/binary"
) )
@@ -16,6 +18,15 @@ func (b *LMDBBackend) SaveEvent(ctx context.Context, evt *nostr.Event) error {
} }
return b.lmdbEnv.Update(func(txn *lmdb.Txn) error { return b.lmdbEnv.Update(func(txn *lmdb.Txn) error {
// check if we already have this id
id, _ := hex.DecodeString(evt.ID)
_, err := txn.Get(b.indexId, id)
if operr, ok := err.(*lmdb.OpError); ok && operr.Errno != lmdb.NotFound {
// we will only proceed if we get a NotFound
return eventstore.ErrDupEvent
}
// encode to binary form so we'll save it
bin, err := nostr_binary.Marshal(evt) bin, err := nostr_binary.Marshal(evt)
if err != nil { if err != nil {
return err return err