982a2dde23
It is currently possible to make non-atomic comparisons of atomic
values:
x := atomic.NewInt32(1)
y := atomic.NewInt32(1)
fmt.Println(*x == *y)
This is undesirable because it loads the value in a non-atomic way. The
correct method is,
x := atomic.NewInt32(1)
y := atomic.NewInt32(1)
fmt.Println(x.Load() == y.Load())
To prevent this, disallow comparison of atomic values by embedding an
uncomparable array into atomics. The empty array adds no runtime cost,
and does not increase the in-memory size of the structs. Inspired by
[go4.org/mem#RO][1].
[1]: 3dbcd07079/mem.go (L42)
Note that the Value struct, which embeds `"sync/atomic".Value` was also
changed. This will break usages in the following form, but that's
acceptable because unkeyed struct literals are among the exceptions
stated in the [Go 1 compatibility expectations][2].
import (
syncatomic "sync/atomic"
"go.uber.org/atomic"
)
atomic.Value{syncatomic.Value{..}}
[2]: https://golang.org/doc/go1compat#expectations
Resolves #72
96 lines
2.8 KiB
Go
96 lines
2.8 KiB
Go
// @generated Code generated by gen-atomicint.
|
|
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package atomic
|
|
|
|
import (
|
|
"encoding/json"
|
|
"sync/atomic"
|
|
)
|
|
|
|
// Uint32 is an atomic wrapper around uint32.
|
|
type Uint32 struct {
|
|
nocmp // disallow non-atomic comparison
|
|
|
|
v uint32
|
|
}
|
|
|
|
// NewUint32 creates a new Uint32.
|
|
func NewUint32(i uint32) *Uint32 {
|
|
return &Uint32{v: i}
|
|
}
|
|
|
|
// Load atomically loads the wrapped value.
|
|
func (i *Uint32) Load() uint32 {
|
|
return atomic.LoadUint32(&i.v)
|
|
}
|
|
|
|
// Add atomically adds to the wrapped uint32 and returns the new value.
|
|
func (i *Uint32) Add(n uint32) uint32 {
|
|
return atomic.AddUint32(&i.v, n)
|
|
}
|
|
|
|
// Sub atomically subtracts from the wrapped uint32 and returns the new value.
|
|
func (i *Uint32) Sub(n uint32) uint32 {
|
|
return atomic.AddUint32(&i.v, ^(n - 1))
|
|
}
|
|
|
|
// Inc atomically increments the wrapped uint32 and returns the new value.
|
|
func (i *Uint32) Inc() uint32 {
|
|
return i.Add(1)
|
|
}
|
|
|
|
// Dec atomically decrements the wrapped uint32 and returns the new value.
|
|
func (i *Uint32) Dec() uint32 {
|
|
return i.Sub(1)
|
|
}
|
|
|
|
// CAS is an atomic compare-and-swap.
|
|
func (i *Uint32) CAS(old, new uint32) bool {
|
|
return atomic.CompareAndSwapUint32(&i.v, old, new)
|
|
}
|
|
|
|
// Store atomically stores the passed value.
|
|
func (i *Uint32) Store(n uint32) {
|
|
atomic.StoreUint32(&i.v, n)
|
|
}
|
|
|
|
// Swap atomically swaps the wrapped uint32 and returns the old value.
|
|
func (i *Uint32) Swap(n uint32) uint32 {
|
|
return atomic.SwapUint32(&i.v, n)
|
|
}
|
|
|
|
// MarshalJSON encodes the wrapped uint32 into JSON.
|
|
func (i *Uint32) MarshalJSON() ([]byte, error) {
|
|
return json.Marshal(i.Load())
|
|
}
|
|
|
|
// UnmarshalJSON decodes JSON into the wrapped uint32.
|
|
func (i *Uint32) UnmarshalJSON(b []byte) error {
|
|
var v uint32
|
|
if err := json.Unmarshal(b, &v); err != nil {
|
|
return err
|
|
}
|
|
i.Store(v)
|
|
return nil
|
|
}
|