uintptr test: Fix overflow on architectures with 32-bit pointers (#100)
Fixes #99 The current uintptr test assumes that pointers are 64-bit, so the test fails to compile on architectures with 32-bit pointers. Instead, cast -1 to uintptr, which matches math.MaxUint64 on 64-bit architectures, and math.MaxUint32 on 32-bit architectures. Verified by using GOARCH=386
This commit is contained in:
committed by
GitHub
parent
557b938325
commit
997edd622f
@@ -22,7 +22,7 @@ package atomic
|
|||||||
|
|
||||||
import (
|
import (
|
||||||
"encoding/json"
|
"encoding/json"
|
||||||
"math"
|
"fmt"
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
"github.com/stretchr/testify/assert"
|
"github.com/stretchr/testify/assert"
|
||||||
@@ -69,8 +69,11 @@ func TestUintptr(t *testing.T) {
|
|||||||
t.Run("String", func(t *testing.T) {
|
t.Run("String", func(t *testing.T) {
|
||||||
// Use an integer with the signed bit set. If we're converting
|
// Use an integer with the signed bit set. If we're converting
|
||||||
// incorrectly, we'll get a negative value here.
|
// incorrectly, we'll get a negative value here.
|
||||||
atom := NewUintptr(uintptr(math.MaxUint64))
|
// Use an int variable, as constants cause compile-time overflows.
|
||||||
assert.Equal(t, "18446744073709551615", atom.String(),
|
negative := -1
|
||||||
|
atom := NewUintptr(uintptr(negative))
|
||||||
|
want := fmt.Sprint(uintptr(negative))
|
||||||
|
assert.Equal(t, want, atom.String(),
|
||||||
"String() returned an unexpected value.")
|
"String() returned an unexpected value.")
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user